search

invertase / denque

The fastest javascript implementation of a double-ended queue. Used by the official Redis, MongoDB, MariaDB & MySQL libraries for Node.js and many other libraries.
https://docs.page/invertase/denque
Apache License 2.0
353 stars 33 forks source link

remove, removeOne and splice methods & tests #7

Closed noevents closed 7 years ago

Salakar commented 7 years ago

Would you mind sorting the linting issues if possible please, the ones listed under index.js header here: https://www.codacy.com/app/mike-diarmid/denque/pullRequest?prid=737043 - You can ignore the complexity ones (unless you can get around them).

Happy to merge today after the changes - will do a release also.

noevents commented 7 years ago

@Salakar Can you merge pr now?

Salakar commented 7 years ago

I've pushed up a few changes to your PR, if you could finish the rest from my review above that'd be great, thanks

noevents commented 7 years ago

Thanks for review! I've fixed coverage and piece of code from this review: https://github.com/invertase/denque/pull/7#pullrequestreview-52394569

Without line from here: https://github.com/invertase/denque/pull/7#pullrequestreview-52392317 node will throw RangeError