search

invertase / docs.page

Instant Open Source docs with zero configuration.
https://docs.page
Apache License 2.0
471 stars 76 forks source link

googleAnalytics config property not working? #209

Closed jenshor closed 2 years ago

jenshor commented 2 years ago

I'm using the googleAnalytics property within the docs.json as used in e.g. melos. However, within analytics.google.com i'm not seeing any reported usage.

Currently, I do not have anything deployed on my main branch because I'm still setting the docs up. Therefore, my docs are currently only deployed as a PR. Is this a problem for the googleAnalytics property?

In addition, I wasn't able to find any documentation regarding this property. Is there anything else that is required to get this working?

cabljac commented 2 years ago

Yeah seems like this is something we supported in v1, and was missed out in v2. I will add this back in :)

jenshor commented 2 years ago

Just checked out the PR. It seems to work. Can this issue be closed?

Great job on enabling this 👍🏻

cabljac commented 2 years ago

Thanks! Only reason I didn't close was because i hadn't tested it yet.