search

invertase / docs.page

Instant Open Source docs with zero configuration.
https://docs.page
Apache License 2.0
458 stars 76 forks source link

Navigation of PR previews not working #380

Closed yousinix closed 1 day ago

yousinix commented 3 days ago

The link that is posted on a PR is just working for the index page, if you try to navigate to any other page, a leading slash before the PR number breaks it all (~XXX)

Steps to reproduce:

  1. Go to https://widgetbook.docs.page/widgetbook~1275 (from this comment).
  2. Try to navigate to any page.

  3. Notice the slash in the URL:

    # Expected
https://widgetbook.docs.page/widgetbook~1275/guides/quick-start

# Actual (has slash between widgetbook and PR number)
https://widgetbook.docs.page/widgetbook/~1275/guides/quick-start
Ehesp commented 1 day ago

This is fixed - custom domains are working again and there was some URL building logic which needed modifying to correct this scenario. Thanks for flagging!