search

invertase / firestore-ios-sdk-frameworks

⚡ Precompiled Firestore iOS SDKs extracted from the Firebase iOS SDK repository release downloads for faster build times.
Apache License 2.0
439 stars 49 forks source link

cloud_firestore: ^3.2.1 compatibility issue #53

Closed awagenfield closed 2 years ago

awagenfield commented 2 years ago

iOS build failing when the following line is added to Podfile

pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '9.2.0'

Despite being much slower, excluding this line results in a successful build.

Error output from Xcode build: ↳ 2022-07-02 17:24:29.747 xcodebuild[47717:6413181] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore 2022-07-02 17:24:29.747 xcodebuild[47717:6413181] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore BUILD FAILED

Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale en-GB) [✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1) [✓] Xcode - develop for iOS and macOS (Xcode 13.4.1) [✓] Chrome - develop for the web [✓] Android Studio (version 2021.2) [✓] VS Code (version 1.68.1)

Keen to put this back when fixed to speed up testing!

arnoutvandervorst commented 2 years ago

When switching from the regular pod to this method, it removes some pods which I guess breaks the build: Removing BoringSSL-GRPC Removing Libuv-gRPC Removing abseil Removing gRPC-C++ Removing gRPC-Core

Error (Xcode): Framework not found FirebaseFirestoreSwift

mikehardy commented 2 years ago

Hmm - it may be that the podspec needs a bit of restructure? I haven't played with this yet and won't have time for a look for a while as I'm traveling - @Salakar maybe you've tried this recently? It seems like you had it working in fact and were just waiting for a 9.3.0 firebase-ios-sdk release ?

If not, perhaps this needs a sync https://github.com/invertase/firestore-ios-sdk-frameworks/blob/19695456ec52caa91e4bc54430dfee6a29fec9ec/FirebaseFirestore.podspec#L19-L21

r-dev-limited commented 2 years ago

Any update on this ?

mikehardy commented 2 years ago

@r-dev-limited it's open source, so the updates you see are the ones that exist:

https://hackernoon.com/i-thought-i-understood-open-source-i-was-wrong-cf54999c097b

I am also interested in seeing updates, but haven't had time myself so I have not posted. What results did you see when you investigated?

mikehardy commented 2 years ago

I'm certain Flutter is building correctly now - assuming you have the correct minimum deployment targets when you use this integration (they are a notch higher than the minimums required if you do not use this pre-compiled version - see https://github.com/invertase/firestore-ios-sdk-frameworks/issues/56#issuecomment-1228644812) so I am going to close this