search

invertase / firestore-ios-sdk-frameworks

⚡ Precompiled Firestore iOS SDKs extracted from the Firebase iOS SDK repository release downloads for faster build times.
Apache License 2.0
439 stars 49 forks source link

Added alternative way to use the latest firebase version for the framework while adding pod #73

Closed sarbagyastha closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

mikehardy commented 1 year ago

🤔 I'm not sure this is a solution that will work in the long run. It will always get the latest version, however, there are very reasonable circumstances where you may not want that, and you are on a previous version on purpose. This would break your build potentially overnight with no changes.

It is much more reliable to parse the local definitions and pull them from there. I do that in my projects by using ruby to parse the json of the app module to get it's firebase-ios-sdk version, then I use that for the dependency here

That results in an internally consistent build vs this where it's network-based and dynamic