search

invertase / firestore-ios-sdk-frameworks

⚡ Precompiled Firestore iOS SDKs extracted from the Firebase iOS SDK repository release downloads for faster build times.
Apache License 2.0
427 stars 48 forks source link

Update README.md to mention latest version in Usage #77

Closed vbuberen closed 10 months ago

vbuberen commented 10 months ago

Small convenience change so people can copy latest version right away from README

mikehardy commented 10 months ago

This will go out of date in at most a couple weeks, so it's still wasted labor - if anything might give a false sense of security since it is so close to up to date people might not realize they need to change it.

I'd rather change it to a text string that obviously doesn't work like "CHANGE TO CURRENT VERSION" or wouldn't it be cooler if it was an automated solution?

Here is one that could work for react-native, certainly something like this should be possible for flutter?

https://github.com/invertase/react-native-firebase/blob/39d4ba4c1f773f9e43796e43aa6d67d868051786/packages/app/RNFBApp.podspec#L1-L4

(altered slightly for different location, if this was used in a Podfile of an app)

require 'json'
package = JSON.parse(File.read(File.join(__dir__, 'node_modules'. '@react-native-firebase', 'app', 'package.json')))
firebase_sdk_version = package['sdkVersions']['ios']['firebase']

pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => firebase_sdk_version
vbuberen commented 10 months ago

Well, yes, it will be outdated thia week already, I guess, but still. Anyway, as you say I am not up to debate about this simple small change.