search

invertase / firestore-ios-sdk-frameworks

⚡ Precompiled Firestore iOS SDKs extracted from the Firebase iOS SDK repository release downloads for faster build times.
Apache License 2.0
427 stars 48 forks source link

fix: ssl dependencies are different after privacy re-spin #94

Closed mikehardy closed 3 months ago

mikehardy commented 5 months ago

See https://github.com/google/grpc-binary/commit/f3ab670621389a5892d47e39c8dda6869feeb9d2

@Salakar - something about the firestore-ios-sdk-frameworks publish has broken again as firestore-ios-sdk works through privacy manifest-related work

You can see from the linked commit that the URL we are searching for in the publish script has moved - it's relatively easy to alter things to pull out the new binary - and I have done so here - but I worry that the switch from a named boringssl thing to an openssl thing means something deeper has happened

@ncooke3 and @paulb777 - apologies for randomly tagging you (I realize I do that a lot 😬 ) but I think you two may have the relevant "yes this is okay" or "oh - no we need to do this..." wisdom here before I/we go too far down the track of forcing this to work. Is it okay to just swap in the new underlying openssl bin for a podspec that's got Boring-SSL in the name as a transitive for the FirebaseFirestore stuff? Will it have all the correct privacy manifest stuff that people will need?

paulb777 commented 5 months ago

Yes, this makes sense to me. Also abseil and grpc naming should be looked at. See https://github.com/firebase/firebase-ios-sdk/pull/12447 and https://github.com/firebase/firebase-ios-sdk/pull/12437

russellwheatley commented 3 months ago

Closing out as this is fixed now 🙏