invertase / flutterfire_cli

A CLI to help with using FlutterFire in your Flutter applications.
Apache License 2.0
164 stars 47 forks source link

feat: Adds support for authenticating via service account #152

Closed josh-burton closed 10 months ago

josh-burton commented 1 year ago

Description

Fixes #151

Supports passing a path to a google service account file which is used for authentication

Type of Change

josh-burton commented 1 year ago

@russellwheatley Are you able to approve the workflow? Does this PR sound like something you'd be interested in merging?

josh-burton commented 1 year ago

@russellwheatley still waiting on you to approve this workflow.

I'd also love an indication of whether this is a change you're interested in merging. Just want to make sure I'm not wasting my time trying to get this through.

simply-alliv commented 1 year ago

Hwllo guys. I appreciate the work you guys do on this CLI, butI am also curious to know what the ETA is on this as we have some CI workloads that would benefit from this feature?

The current state of the CLI causes the program to sometimes fail due to authentication. I have a service account that would probably allow me to solve the authentication issue by using it in the Flutter fire CLI.

Thanks

russellwheatley commented 1 year ago

Hey @josh-burton, the next release isn't for at least a couple of weeks, so I will investigate if CI failure is occurring as a result of PR which I suspect it is before merging.

josh-burton commented 1 year ago

Hey @josh-burton, the next release isn't for at least a couple of weeks, so I will investigate if CI failure is occurring as a result of PR which I suspect it is before merging.

Thank you!

russellwheatley commented 10 months ago

@josh-burton - do you mind fixing merge conflict and merging with latest on main? I think the tests ought to pass now ๐Ÿ‘. Thanks!

josh-burton commented 10 months ago

@josh-burton - do you mind fixing merge conflict and merging with latest on main? I think the tests ought to pass now ๐Ÿ‘. Thanks!

Sure, rebased now.

russellwheatley commented 10 months ago

@josh-burton - I was trying to figure out why this was failing CI ๐Ÿค” . I realised secrets are not available for forked pull requests. I've ran locally and it works fine. Thanks once again ๐ŸŽ‰

josh-burton commented 10 months ago

@josh-burton - I was trying to figure out why this was failing CI ๐Ÿค” . I realised secrets are not available for forked pull requests. I've ran locally and it works fine. Thanks once again ๐ŸŽ‰

thanks for merging :)

artemsorochan commented 4 months ago

Thanks for this feature! It would be good to add any notes on this to docs. For example, what is the minimal required role for service account for configure command?