Closed josh-burton closed 10 months ago
@russellwheatley Are you able to approve the workflow? Does this PR sound like something you'd be interested in merging?
@russellwheatley still waiting on you to approve this workflow.
I'd also love an indication of whether this is a change you're interested in merging. Just want to make sure I'm not wasting my time trying to get this through.
Hwllo guys. I appreciate the work you guys do on this CLI, butI am also curious to know what the ETA is on this as we have some CI workloads that would benefit from this feature?
The current state of the CLI causes the program to sometimes fail due to authentication. I have a service account that would probably allow me to solve the authentication issue by using it in the Flutter fire CLI.
Thanks
Hey @josh-burton, the next release isn't for at least a couple of weeks, so I will investigate if CI failure is occurring as a result of PR which I suspect it is before merging.
Hey @josh-burton, the next release isn't for at least a couple of weeks, so I will investigate if CI failure is occurring as a result of PR which I suspect it is before merging.
Thank you!
@josh-burton - do you mind fixing merge conflict and merging with latest on main? I think the tests ought to pass now ๐. Thanks!
@josh-burton - do you mind fixing merge conflict and merging with latest on main? I think the tests ought to pass now ๐. Thanks!
Sure, rebased now.
@josh-burton - I was trying to figure out why this was failing CI ๐ค . I realised secrets are not available for forked pull requests. I've ran locally and it works fine. Thanks once again ๐
@josh-burton - I was trying to figure out why this was failing CI ๐ค . I realised secrets are not available for forked pull requests. I've ran locally and it works fine. Thanks once again ๐
thanks for merging :)
Thanks for this feature! It would be good to add any notes on this to docs. For example, what is the minimal required role for service account for configure
command?
Description
Fixes #151
Supports passing a path to a google service account file which is used for authentication
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore