invertase / flutterfire_cli

A CLI to help with using FlutterFire in your Flutter applications.
Apache License 2.0
171 stars 47 forks source link

request: pub dev package & rework iOS build phase #223

Open EArminjon opened 11 months ago

EArminjon commented 11 months ago

Is there an existing feature request for this?

Command

flutterfire

Description

I saw some packages providing cli like flutter_native_splash using the dart command. (ex: dart run flutter_native_splash:create)

I think it can be interesting to have a similar usage for this script as it depend of dart. Installing this tool inside project dev-dependencies instead of global system command will be better. If you have several projects using several flutter versions, it's a nightmare to handle this good command...

Today, the flutterfire script is launched when we build or run the app. It make sens to put it as project dependency.

Instead of having something like :

#!/bin/bash
PATH=${PATH}:$FLUTTER_ROOT/bin:$HOME/.pub-cache/bin
flutterfire bundle-service-file ...

We could have something like :

#!/bin/bash
PATH=${PATH}:$FLUTTER_ROOT/bin
dart run flutterfire bundle-service-file ...

This will remove the dependency of the $HOME and I think this will be better for projects using tools like FVM.

Reasoning

Help developers to integrate easily this package. Help developers to work easily on multiple flutter project using different dart and flutter version.

Additional context and comments

No response

EArminjon commented 11 months ago

Update : Removing on my side my fvm 'global' version and my 'dart' global binary help me to bypass a problem around multiple version of dart.

I keep this PR open because I believe that it can be a good things to have a migration from dart global to project dev-dependency.

ebsangam commented 7 months ago

Exactly currently we were having this issue because of different flutterfire version in our system and it was really hard to identify the issue.

github-actions[bot] commented 1 day ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

EArminjon commented 1 day ago

This issue still requires attention I guess.