invertase / melos

๐ŸŒ‹ A tool for managing Dart projects with multiple packages. With IntelliJ and Vscode IDE support. Supports automated versioning, changelogs & publishing via Conventional Commits.
https://melos.invertase.dev/~melos-latest
Apache License 2.0
1.11k stars 198 forks source link

feat: Add enforce lockfile bootstrap command config #600

Closed Ayman-Barghout closed 8 months ago

Ayman-Barghout commented 9 months ago

Description

This change is to ensure which versions are being used, as minor changes sadly can have breaking changes to your codebase (conflicting names for example), so this option is to make sure all machines/environments are running the same versions.

This resolves #575.

Edit: Enforcing it on CI isn't a good idea as some monorepos don't check in lock files for packages if they are published, so it should always be optional.

Type of Change

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

spydon commented 9 months ago

@Ayman-Barghout the analyzer warnings are already fixed in #602, no harm in fixing them in here too to show that it is green though, as long as the other one is merged first. :)

Ayman-Barghout commented 9 months ago

@Ayman-Barghout the analyzer warnings are already fixed in #602, no harm in fixing them in here too to show that it is green though as long as the other one is merged first. :)

Oh, my bad, didn't notice :) sure thing, I am gonna wait till #602 merge then ๐Ÿ™Œ

Salakar commented 9 months ago

Could we add this as a flag to bootstrap too, melos bootstrap --enforce-lockfile?

spydon commented 8 months ago

@Ayman-Barghout did you see Salakar's comment?

Ayman-Barghout commented 8 months ago

@Ayman-Barghout did you see Salakar's comment?

Sadly not, just noticed it when you pinged ๐Ÿ™‚ will work on it ASAP

spydon commented 8 months ago

@Ayman-Barghout you can have a look at #604 to see how to do it :)

Ayman-Barghout commented 8 months ago

@spydon @Salakar fixed and thanks for the help! ๐Ÿ™