Closed Ayman-Barghout closed 8 months ago
@Ayman-Barghout the analyzer warnings are already fixed in #602, no harm in fixing them in here too to show that it is green though, as long as the other one is merged first. :)
@Ayman-Barghout the analyzer warnings are already fixed in #602, no harm in fixing them in here too to show that it is green though as long as the other one is merged first. :)
Oh, my bad, didn't notice :) sure thing, I am gonna wait till #602 merge then ๐
Could we add this as a flag to bootstrap too, melos bootstrap --enforce-lockfile
?
@Ayman-Barghout did you see Salakar's comment?
@Ayman-Barghout did you see Salakar's comment?
Sadly not, just noticed it when you pinged ๐ will work on it ASAP
@Ayman-Barghout you can have a look at #604 to see how to do it :)
@spydon @Salakar fixed and thanks for the help! ๐
Description
This change is to ensure which versions are being used, as minor changes sadly can have breaking changes to your codebase (conflicting names for example), so this option is to make sure all machines/environments are running the same versions.
This resolves #575.
Edit: Enforcing it on CI isn't a good idea as some monorepos don't check in lock files for packages if they are published, so it should always be optional.
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore