search

invertase / melos

🌋 A tool for managing Dart projects with multiple packages. With IntelliJ and Vscode IDE support. Supports automated versioning, changelogs & publishing via Conventional Commits.
https://melos.invertase.dev/~melos-latest
Apache License 2.0
1.11k stars 198 forks source link

request: commit link in submodule's change log is wrong #621

Open philos3 opened 8 months ago

philos3 commented 8 months ago

Is there an existing feature request for this?

Command

melos version --all

Description

melos.yaml


name: melosExample
#repository: https://gitlab.melos.pro/mobile/melos
repository:
  type: gitlab
  origin: https://gitlab.melos.pro
  owner: mobile
  name: melos

melosExample for repository https://gitlab.melos.pro/mobile/melos [submodule "component/melos1"] for repository https://gitlab.melos.pro/mobile/melos1 [submodule "component/melos2"] for repository https://gitlab.melos.pro/mobile/melos2 [submodule "component/melos3"] for repository https://gitlab.melos.pro/mobile/melos3 [submodule "component/melos4"] for repository https://gitlab.melos.pro/mobile/melos4

here is the chagelog

## 2023-12-22

### Changes

---

Packages with breaking changes:

- There are no breaking changes in this release.

Packages with other changes:

- [`melos1` - `v0.0.2`](#melos1---v002)
- [`melos2` - `v7.4.0`](#melos2---v740)
- [`melos3` - `v1.1.0`](#melos3---v110)
- [`melos4` - `v7.4.0`](#melos4---v740)
- [`melosExample` - `v7.4.0`](#melosExample---v740)

---

#### `melos1` - `v0.0.2`
- **FIX**: XXXXXXXXXXXX. ([f849b087](https://gitlab.melos.pro/mobile/melos/-/commit/f849b087796316054b0de6103ca65a3e6c92686c))

#### `melos2` - `v7.4.0`
- **FIX**: XXXXXXXXXXXX. ([f849b087](https://gitlab.melos.pro/mobile/melos/-/commit/f849b087796316054b0de6103ca65a3e6c92686c))

#### `melos3` - `v1.1.0`
- **FIX**: XXXXXXXXXXXX. ([f849b087](https://gitlab.melos.pro/mobile/melos/-/commit/f849b087796316054b0de6103ca65a3e6c92686c))

#### `melos4` - `v7.4.0`
- **FIX**: XXXXXXXXXXXX. ([f849b087](https://gitlab.melos.pro/mobile/melos/-/commit/f849b087796316054b0de6103ca65a3e6c92686c))

## `melosExample` - `v7.4.0`
- **FIX**: XXXXXXXXXXXX. ([f849b087](https://gitlab.melos.pro/mobile/melos/-/commit/f849b087796316054b0de6103ca65a3e6c92686c))

we can see all the module commit links of chagelog are all start with "https://gitlab.melos.pro/mobile/melos/-/commit/", of course the chagelog links under submodule melos1 、melos2、melos3、melos4 are all wrong，it should be ： https://gitlab.melos.pro/mobile/melos1/-/commit/XXXXX https://gitlab.melos.pro/mobile/melos2/-/commit/XXXXX https://gitlab.melos.pro/mobile/melos3/-/commit/XXXXX https://gitlab.melos.pro/mobile/melos4/-/commit/XXXXX

Reasoning

I think it is gread to support submodule repository

Additional context and comments

No response

philos3 commented 8 months ago

image

after exc melos version --all，can we keep the style of flutter yaml version，just like 7.3.28+7328 to 7.3.29+7329

spydon commented 8 months ago

I can understand why you would want to have submodules in your monorepo and connect them to the rest of your packages in there, but to version them from a repository where their code doesn't actually live sounds like a pretty bad pattern since it can't update the versions in their pubspec files or add local changelogs to them. Or maybe I misunderstand your request?

philos3 commented 8 months ago

What I want is just the automatic generation module's changelog,and to auto increase the main project version