invertase / melos

๐ŸŒ‹ A tool for managing Dart projects with multiple packages. With IntelliJ and Vscode IDE support. Supports automated versioning, changelogs & publishing via Conventional Commits.
https://melos.invertase.dev/~melos-latest
Apache License 2.0
1.08k stars 193 forks source link

test: fix flaky test in linux CI/CD environments #677

Closed jessicatarra closed 4 months ago

jessicatarra commented 4 months ago

Description

This PR addresses the issue of flaky test results when executing the run command test (verifies that a melos script can call another script containing steps, and ensures all commands in those steps are executed successfully) in Linux CI/CD environments, as reported in issue #670.

Closes #670

Type of Change

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

Salakar commented 4 months ago

@jessicatarra off topic but we'd love to sponsor you through GitHub sponsors for all the good work you're doing, are you able (and interested) in setting up your GitHub sponsors profile? ๐Ÿ˜…

spydon commented 4 months ago

@jessicatarra is the failing linux test related? Or is that due to other type of flakiness? :sweat_smile:

jessicatarra commented 4 months ago

@spydon it's actually another one but a very similar issue. I'll investigate and consider applying a similar fix to resolve it. Also, I think it may be a good idea to run the CI/CD pipeline a couple times before merging this and see if the result is constant

Salakar commented 4 months ago

@spydon it's actually another one but a very similar issue. I'll investigate and consider applying a similar fix to resolve it. Also, I think it may be a good idea to run the CI/CD pipeline a couple times before merging this and see if the result is constant

I've triggered another CI run

spydon commented 4 months ago

I've triggered another CI run

Haha, we are sitting and triggering re-runs in parallel. :smile:

Salakar commented 4 months ago

I've triggered another CI run

Haha, we are sitting and triggering re-runs in parallel. ๐Ÿ˜„

Haha, woops! ๐Ÿ˜…


Seems to be a new failure:

image

spydon commented 4 months ago

Since it seems to be a different error I suggest that we merge this one and fix the other one as a follow-up, or what do you think @jessicatarra?

jessicatarra commented 4 months ago

@spydon Yes, I agree! it may require a much longer investigation and the root cause may be different from the issues mentioned here

jessicatarra commented 4 months ago

@jessicatarra off topic but we'd love to sponsor you through GitHub sponsors for all the good work you're doing, are you able (and interested) in setting up your GitHub sponsors profile? ๐Ÿ˜…

And before I forget @Salakar, I'm in the process of enabling GitHub Sponsors on my profile. I'll let you know when that happens. Thank you so much!

jessicatarra commented 4 months ago

@Salakar Happy to announce that my profile already has GitHub Sponsors enabled!