search

invertase / melos

🌋 A tool for managing Dart projects with multiple packages. With IntelliJ and Vscode IDE support. Supports automated versioning, changelogs & publishing via Conventional Commits.
https://melos.invertase.dev/~melos-latest
Apache License 2.0
1.13k stars 201 forks source link

feat: Change concurrent log to sequential log #679

Closed koji-1009 closed 6 months ago

koji-1009 commented 6 months ago

Description

issue #668

Improvements melos analyse log so that the output is the same when the -c option is specified as when it is not specified. The String? group property is added for grouping when logging output. In the case of -c 1, this option is not needed. (Log output is done sequentially.) In the case of -c 2, all logs are output after the process is complete.

Existing buffer-flush was deprecated, so it was named group-buffer for convenience. If that is not good, please point it out. Thanks for the useful tools.

no issue case

main branch log ```console # koji @ Mochi in ~/packages/melos on git:main o [19:03:18] $ melos analyze -c 1 Building package executable... Built melos:melos. $ melos analyze └> dart analyze └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... No issues found! melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... No issues found! melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze └> SUCCESS # koji @ Mochi in ~/packages/melos on git:main o [19:03:24] $ melos analyze -c 2 Building package executable... Built melos:melos. $ melos analyze └> dart analyze --concurrency 2 └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Analyzing conventional_commit... Analyzing melos... No issues found! No issues found! Analyzing melos... No issues found! ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze --concurrency 2 └> SUCCESS ```
this branch log ```console # koji @ Mochi in ~/packages/melos on git:feat/concurrent_log o [19:05:11] $ melos analyze -c 1 Building package executable... Built melos:melos. $ melos analyze └> dart analyze └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... No issues found! melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... No issues found! melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze └> SUCCESS # koji @ Mochi in ~/packages/melos on git:feat/concurrent_log o [19:05:18] $ melos analyze -c 2 Building package executable... Built melos:melos. $ melos analyze └> dart analyze --concurrency 2 └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... No issues found! melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... No issues found! melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze --concurrency 2 └> SUCCESS ```

find issue case

main branch log ```console # koji @ Mochi in ~/packages/melos on git:main o [19:12:36] $ melos analyze -c 1 Building package executable... Built melos:melos. $ melos analyze └> dart analyze └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... info - lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... info - packages/melos/lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze └> SUCCESS # koji @ Mochi in ~/packages/melos on git:main x [19:12:51] $ melos analyze -c 2 Building package executable... Built melos:melos. $ melos analyze └> dart analyze --concurrency 2 └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Analyzing conventional_commit... Analyzing melos... No issues found! info - lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. Analyzing melos... info - packages/melos/lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze --concurrency 2 └> SUCCESS ```
this branch log ```console # koji @ Mochi in ~/packages/melos on git:feat/concurrent_log x [19:14:58] $ melos analyze -c 1 Building package executable... Built melos:melos. $ melos analyze └> dart analyze └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... info - lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... info - packages/melos/lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze └> SUCCESS # koji @ Mochi in ~/packages/melos on git:feat/concurrent_log x [19:15:07] $ melos analyze -c 2 Building package executable... Built melos:melos. $ melos analyze └> dart analyze --concurrency 2 └> RUNNING (in 3 packages) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- conventional_commit: Analyzing conventional_commit... No issues found! conventional_commit: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos: Analyzing melos... info - lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- melos_workspace: Analyzing melos... info - packages/melos/lib/src/commands/analyze.dart:30:4 - Missing a required trailing comma. - require_trailing_commas 1 issue found. melos_workspace: SUCCESS ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- $ melos analyze └> dart analyze --concurrency 2 └> SUCCESS ```

Type of Change

koji-1009 commented 6 months ago

Sure, I'll give it a try!

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

spydon commented 6 months ago

@koji-1009 there seems to be a test failing in this PR

koji-1009 commented 6 months ago

I'm sorry! I had unintentionally changed the label flag to true when I changed it from logger.stderr to logger.error.