invertase / notifee

⚛️ A feature rich notifications library for React Native.
https://notifee.app
Apache License 2.0
1.88k stars 228 forks source link

fix(android): android gradle plugin 8 compatibility #907

Closed mikehardy closed 11 months ago

mikehardy commented 1 year ago

This was required locally when testing the module with android gradle plugin 8 which is included in upcoming react-native 0.73 release

Will also serve as an opening round of "is CI still working" in this repo

codecov[bot] commented 1 year ago

Codecov Report

Merging #907 (7f5f9e2) into main (4e59dcf) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #907 +/- ## ======================================= Coverage 77.41% 77.41% ======================================= Files 32 32 Lines 1691 1691 Branches 567 567 ======================================= Hits 1309 1309 Misses 333 333 Partials 49 49 ```
mikehardy commented 1 year ago

Spoiler alert: CI not working. That's alright, I'm the CI whisperer. Will be working shortly

github-actions[bot] commented 11 months ago

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

fobos531 commented 11 months ago

Hey Mike,

with the official release of 0.73, is there anything holding this PR back?

mikehardy commented 11 months ago

Yeah - I've got the go ahead to work in this repo now but when I went to check things and make sure I didn't break something by merging this I realized that I couldn't even build+test the repo on current toolchains 😬

Working through that with #933 then I'll get this out as a sort of "emergency priority" and then start reviving staled out issues+PRs and getting a regular release cadence going

mikehardy commented 11 months ago

I snuck in a bunch of unrelated Flutter CI changes since I needed to re-run CI a bunch anyway. Got all checks to go ✅ 🥳

mikehardy commented 11 months ago

This was just released as v7.8.1 - should be good to go @fobos531 - first time I've published this repo in a long long time, please let me know how it goes as you test integrate it, thanks!

fobos531 commented 11 months ago

Thank you so much, appreciated!