search

invertase / notifee

⚛️ A feature rich notifications library for React Native.
https://notifee.app
Apache License 2.0
1.88k stars 228 forks source link

iOS: Own userNotificationCenter:didRecieveNotificationResponse:withCompletionHandler is overwritten #984

Closed gotcha84 closed 4 months ago

gotcha84 commented 9 months ago

Reviving #925 as it is still an issue.

I'm facing the same issue on iOS when trying to use Notifee and Iterable. The Notifee delegate seems to be overwriting the Iterable delegate.

The culprit seems to be this block of code. It is parsing the non-Notifee notification into the notifeeNotification object which prevents the _originalDelegate from handling it in the else-if clause at the bottom of the function.

akshay-engage commented 9 months ago

Came across similar issue. Thanks to @gotcha84 With his PR changes issue was resolved. Looking for you new release with this fix added

github-actions[bot] commented 8 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

gotcha84 commented 8 months ago

Not fixed, still requires attention. @mikehardy or @helenaford - I have a PR out with a potential fix, would you be able to take a quick look and see if it's something worth pulling in?

github-actions[bot] commented 7 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

gezquinndesign commented 7 months ago

Still requires attention. I'm just going to patch-package for now.

github-actions[bot] commented 6 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

StasSokolov1 commented 6 months ago

+1

github-actions[bot] commented 5 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.