invertase / react-native-apple-authentication

A React Native library providing support for Apple Authentication on iOS and Android.
Other
1.42k stars 223 forks source link

missing feature: Make it possible to change apple login button text #306

Closed adamSplendex closed 2 years ago

adamSplendex commented 2 years ago

Hey,

A simple but super important part of this little lib is missing, that is changing the Apple login text. We are developing apps for international clients and many of them wants their social login buttons translated to their language.

Now it is not possible with this lib, and sadly we already implemented the full auth login and such, but because of this we need to use another solution(which takes time)

Expected behaviour:

Apple Login Button's text should be changeable with a prop.

Thanks,

Adam CTO @ Splendex.io

mikehardy commented 2 years ago

Hi there "CTO @Splendex" - those are system-generated dialogs, we simply ask the operating system to "start the auth process" and the system takes it from there

So they will show up in the current system language.

I use this module in a multi-language app and the dialogs show in up in the system language

There's no action here, it works, and if it does not work, then it's an Apple bug - you should file with them that they are missing a translation in to some language

adamSplendex commented 2 years ago

Thanks for the fast reply :)

image

I meant for changing this text

We made it work with another solution, like this:

image

All in all it would be a nice to have thing here too.

Have a great week,

cheers

mikehardy commented 2 years ago

I addressed that:

those are system-generated dialogs, we simply ask the operating system to "start the auth process" and the system takes it from there

Getting in to a competitive programming competition with Apple where we try to wrap all their functionality but with facility to internationalize text they have already internationalized at the system level seems like an extremely inefficient use of time.

Flow is: We ask system to start apple authentication flow, system starts showing system dialogs translated in system by Apple

That's pretty efficient as Apple has lots of people working on their system and they handle the translation

I don't see a feature gap here

adamSplendex commented 2 years ago

All rightie, I get you, then something must have been weird with the language detection on the system layer because for us it was always English on all simulators and all devices (with nonenglish language as system lang).

Thank you for your time!

Kind regards,

Adam

firstChairCoder commented 1 year ago

adamSplendex

Hi, @adamSplendex May I please ask how you were able to achieve changing the button text without just leaving it up to the system?