search

invertase / react-native-apple-authentication

A React Native library providing support for Apple Authentication on iOS and Android.
Other
1.36k stars 215 forks source link

fix(android): declare namespace / buildconfig options for gradle plugin 8+ compatibility #329

Closed ivanignatiev closed 8 months ago

ivanignatiev commented 8 months ago

Change is required as per announce in community: https://github.com/react-native-community/discussions-and-proposals/issues/671

Fixes #328

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

OHHAKO commented 8 months ago

@ivanignatiev hi, thanks for fixing it! you specified the agp version. but why? I contributed to another repository, but didn't use the terms like you. Because of course I didn't know it was necessary.

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION if (agpVersion.tokenize('.')[0].toInteger() >= 7)

ivanignatiev commented 8 months ago

@OHHAKO hi !

I am not sure that it is really really necessary (I am not Java/Grandle expert). Before React Native requirements upgrades, the namespace was taken from AndroidManifest.xml.

For me, it is just a safe formula for backward compatibility for guys who will use the module with older versions of React Native.

mikehardy commented 8 months ago

After updating the example app + CI so things would actually build, I pulled this and ran it locally, and it works fine. CI will check it after a merge to main as well