search

invertase / react-native-apple-authentication

A React Native library providing support for Apple Authentication on iOS and Android.
Other
1.42k stars 223 forks source link

feat: support for VisionOS #352

Closed j6alvarez closed 2 months ago

j6alvarez commented 2 months ago

I have been doing some work with this repo https://github.com/callstack/react-native-visionos

And wanted to contribute sharing what made it work for me following the instructions in this post

This allows to run appleAuth methods for react-native-visionos

Fixes #350

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

mikehardy commented 2 months ago

😆 indeed when I ran yarn example:macos what I feared happened - the build was broken for macOS because of the UIKit.h inclusion. I swear I had seen that somewhere but also I checked and couldn't find it.

Anyway, one quick change later and it's good

#if TARGET_OS_IPHONE
#import <UIKit/UIKit.h>
#endif
j6alvarez commented 2 months ago

Uh nice that you fixed it easily, I haven't use the library for macOS, just for visionOS and iOS. Thanks for fixing this 🙏🏽