invertase / react-native-firebase-docs

DEPRECATED: For RNFB v5 only.
https://rnfirebase.io/docs
Other
189 stars 242 forks source link

docs(analytics): max char length for event param name & value #243

Closed joshbuchea closed 4 years ago

joshbuchea commented 4 years ago

This PR clarifies the difference between the maximum character lengths supported for event parameter names and event parameter values.

Source: https://support.google.com/firebase/answer/9237506?hl=en

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

joshbuchea commented 4 years ago

Good call 👍

See Collection and configuration limits in Firebase Help for additional information.

☝️?

Perhaps added below or appended to the end of the note about maximum character length?

joshbuchea commented 4 years ago

I just noticed the docs website currently has an additional note under logEvent in Analytics that is not present in master. Is there a different branch I should be working from rather than master?

mikehardy commented 4 years ago

@joshbuchea your suggestion above seems fine by me - for your question about where the docs are, the answer is different depending on which docs you're looking for.

For RNFBv5, you edit v5.x.x docs on a different repo - https://github.com/invertase/react-native-firebase-docs/tree/v5.x.x - and it auto-syncs with rnfirebase.io

For RNFBv6 you edit the docs in this repo on the master branch, and it auto-syncs with invertase.io's docs site

A little confusing on the RNFBv5 side but RNFBv6 has already cleaned that all up for future, and eventually v5 stuff will fall away

joshbuchea commented 4 years ago

Thank you for the thorough answer Mike!

Added a link to the source docs ✅

Salakar commented 4 years ago

LGTM - thank you @joshbuchea 🎉