search

invertase / react-native-firebase-starter

DEPRECATED: For RNFB v5 only.
https://rnfirebase.io/docs
Other
1.17k stars 334 forks source link

Starter doesn't work on all supported react-native android versions (>=API16) #103

Closed mikehardy closed 5 years ago

mikehardy commented 5 years ago

The stock starter doesn't work on the full API skew supported by React-Native - they support down to API16 (as does my app) but this is set to a minimum API of API18

I'm not sure if there is a technical reason for this or not, but it appears Firebase itself supports those APIs just fine (I believe they target down to 14 or 15 still)

I was able to get a test app based on this starter working down to API16 though, with just a few changes - MultiDex support (which seems like it should be required for anything below API21, really?) and finishing the incomplete example app upgrade to react-native 0.58.x (the package.json depends on rc2 but hadn't done all the steps so gradle support lagged and there's a build error until 0.58.x is set up for real)

This project is valuable to me, I'd be happy to make a PR if you are interested?

mikehardy commented 5 years ago

@Salakar just checking interest before I move on from this area of work, can close otherwise

mikehardy commented 5 years ago

@dewelloper please open a new issue if you need to, and include relevant details or no one will know what or why. The starter worked great for the APIs that it supported, and adb refuses to install the APK on ones it doesn't (with a clear message), so this was not a build + sync issue at all.

dewelloper commented 5 years ago

oke @mikehardy

Salakar commented 5 years ago

@mikehardy this is a limitation caused by notifications I believe or one of the other packages, can't quite remember off the top of my head - will look into it but hoping this will no longer be the case with v6 - I want to add an Android API 16 CI stage nearer the release of v6.0.0 to make sure everything stays supported from min to max

I'd accept a PR though of course for the starter if you have it working on API 16 👏

mikehardy commented 5 years ago

I have the starter working down to API15 - the full react-native skew - with correct MultiDex :-)

I'll see what I can do package up the changes - it's a bit hard to back-propagate changes in the starter because of the name change, but I understand why that exists because of firebase package/bundle name uniqueness needs

Salakar commented 5 years ago

@mikehardy It'd only be a short term thing so if it's a lot effort then I wouldn't worry too much.

The v6 starter just init's using RN's init template 🙃 so will be less conflicty

https://github.com/invertase/react-native-firebase/tree/master/packages/template

If I had a dollar though for everytime I mention v6 as the solution to something 😅