search

invertase / react-native-firebase-starter

DEPRECATED: For RNFB v5 only.
https://rnfirebase.io/docs
Other
1.17k stars 334 forks source link

fix: correctly support API<21 with proper MultiDex support #110

Closed mikehardy closed 5 years ago

mikehardy commented 5 years ago

Also, old Android APIs can't do network forwards, so dev bundles don't work, you have to pre-bundle the react-native app and include it even on dev builds. So I added an android-bundle npm script to run before starting the app on old devices

This is very difficult to test because you must have an actual device with android 4.x on it. The emulators for those APIs don't have the Google APIs at a level sufficient to test anymore (they are too old and you can't upgrade them easily).

I happen to have an API17 craptablet laying around which is the only reason I noticed this (and was able to fix it and test it)

Fixes #103

mikehardy commented 5 years ago

@Salakar - you and I chatted about this briefly, and I made the PR but forgot to follow up so this was probably lost in the shuffle, either way - here is the PR that makes the firebase starter work cleanly on API16, so it supports the full react-native API skew

Mostly it's just implementing MultiDex correctly, thus the tiny diff

mikehardy commented 5 years ago

Possibly worth noting, this is how I am configured on my day-job project, in production, with regular testing on a 🤢 API17 tablet from the year 1964

mikehardy commented 5 years ago

@Salakar - can we merge this? I'm about to try a demo app for notifications/messaging and I only have two real devices, one of which only works with these changes

Salakar commented 5 years ago

Merged, thanks for this @mikehardy 🎉