search

invertase / react-native-firebase-starter

DEPRECATED: For RNFB v5 only.
https://rnfirebase.io/docs
Other
1.17k stars 334 forks source link

upgrade to react-native 0.60.3 #125

Closed MrHazimAli closed 4 years ago

MrHazimAli commented 5 years ago

does this boilerplate will support react-native 0.60.3 soon ?

kutaisan commented 4 years ago

waiting for update

mikehardy commented 4 years ago

Why wait? Propose a PR and it'll be done and you will earn internet fame and prestige

mikehardy commented 4 years ago

In the meantime, https://github.com/mikehardy/rnfbdemo/blob/master/make-demo.sh

If you run RNVERSION=60 ./make-demo.sh in there you get a more-or-less-working RN60 boilerplate

raaannzzz commented 4 years ago

In the meantime, https://github.com/mikehardy/rnfbdemo/blob/master/make-demo.sh

If you run RNVERSION=60 ./make-demo.sh in there you get a more-or-less-working RN60 boilerplate

@mikehardy I tried to install the boilerplate, but when i run it, it automatically crash after splash screen

raaannzzz commented 4 years ago

nevermind my concern, the boilerplate is working well

uguraktas commented 4 years ago

when will the 0.60 version be released ?

mikehardy commented 4 years ago

@uguraktas right after someone updates it! PRs happily accepted. Asking for your free stuff faster, :man_shrugging:

Please note that I've updated the boilerplate itself to split out the RN59 version, so now for RN60 boilerplate you just want to run 'make-demo.sh' and for RN59 you would run 'make-demo-rn59.sh'

makedirectory commented 4 years ago

@mikehardy I have react-native-firebse-starter updated for react native .60.5, I looked over the docs and see that you allow access to open PRs but can't seem to push my code to a new branch. I'm still new to github and open source community. Can you please let me know how I can push my code for you & the rest of the team to review and/or point me in the right direction?

And of course, thank you for this wonderful boilerplate it's been very handy!

UPDATE: PR made here: https://github.com/invertase/react-native-firebase-starter/pull/135 please let me know if any issues come up

mikehardy commented 4 years ago

Just an update for others: The linked PR #135 from @makedirectory has been reviewed and looks good. Giving another day for others to maybe review then if there is no dissent I'll merge and we can all move forward, just in time for react-native 0.61

mikehardy commented 4 years ago

@makedirectory is the hero we needed! This is merged, and the starter is now super up to date - thank yoU!