search

invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.64k stars 2.21k forks source link

Implement the in/array-contains-any queries #2842

Closed FuriioS closed 4 years ago

FuriioS commented 4 years ago

Firebase launched yesterday the in/array-contains-any queries. I would like the team implements these requests ASAP : )

Reference: https://firebase.googleblog.com/2019/11/cloud-firestore-now-supports-in-queries.html https://firebase.google.com/docs/firestore/query-data/queries

Salakar commented 4 years ago

We're still waiting on Android SDK support;

image

Salakar commented 4 years ago

Android SDK is now up, we'll get this looked at 🎉

meftunca commented 4 years ago

Will 6.1.0 be released today? :)

Ehesp commented 4 years ago

@meftunca not today sorry, this isn't a trivial implementation so will take a few days. Should have something up around the weekend.

Ehesp commented 4 years ago

@meftunca if you want it sooner, a PR is welcome.

meftunca commented 4 years ago

@meftunca if you want it sooner, a PR is welcome.

Yes I would like to have it earlier if possible

Ehesp commented 4 years ago

Started a branch: https://github.com/invertase/react-native-firebase/commit/d74be16f304b41be2b71e4a4077a91746ebb613b

Still needs testing & iOS support.

meftunca commented 4 years ago

Hello, what should I do to test the latest version in my project?

Ehesp commented 4 years ago

I know you're keen, but you're best waiting until we release it. The branch is WIP and needs properly testing. Why don't you just mock the results locally for now and wait until we release - it'll be a few days.

meftunca commented 4 years ago

Hello, I didn't get the feature I expected in the last update. How soon will you make the update available?

mikehardy commented 4 years ago

@meftunca it isn't merged yet, but it appears you can pull the branch and test it if you like https://github.com/invertase/react-native-firebase/compare/@feat/firestore/in-query

mikehardy commented 4 years ago

can subscribe to the PR here as well, to see when it is merged https://github.com/invertase/react-native-firebase/pull/2868

meftunca commented 4 years ago

can subscribe to the PR here as well, to see when it is merged #2868

thanks :)

meftunca commented 4 years ago

I have a little question. Can I add commit from github as package.json dependencies?

meftunca commented 4 years ago

example "@react-native-firebase/firestore":"https://github.com/invertase/react-native-firebase/packages/firestoe/#d74be16f304b41be2b71e4a4077a91746ebb613b"

FuriioS commented 4 years ago

example "@react-native-firebase/firestore":"https://github.com/invertase/react-native-firebase/packages/firestoe/#d74be16f304b41be2b71e4a4077a91746ebb613b"

npm install --save user/repo#branch

meftunca commented 4 years ago

example "@react-native-firebase/firestore":"https://github.com/invertase/react-native-firebase/packages/firestoe/#d74be16f304b41be2b71e4a4077a91746ebb613b"

npm install --save user/repo#branch

Can you suggest a working example for Cloud firestore?

mikehardy commented 4 years ago

You can, but it's a little more complicated than that for monorepos or repos that are in typescript unfortunately as they aren't published as a copy. I have to admit - I only converted my work project to a monorepo recently and I'm not sure how I would depend on just one package from git from inside a monorepo.

I have needed to do this before and after reading up on npm and yarn's capabilities, they cannot do it, but you can fake it with https://github.com/ramasilveyra/gitpkg

If I understand correctly, you create your own git repo on github that is just for publishing these temporary packages. Then you use gitpkg to create a tag of just the files you want from the monorepo (or post-build from a package that needs to be built) and you publish that. Then you depend on your github repo at that tag, and it works? Haven't tried it but the success reports were universal for those with this need.

Might work for you to try this module from this branch

jerryheir commented 4 years ago

Uhmmm, Hi Guys, March 27th and I am still on v5.6.0.

mikehardy commented 4 years ago

@jerryheir Happy March 27th!

jerryheir commented 4 years ago

😂 Okay this response is very funny. I can't stop laughing

mikehardy commented 4 years ago

Happy you took it that way, I realized after I typed it...it could go either way, but man I'm stuck in quarantine in my house 2 weeks and my family is tired of my terrible jokes, so I guess github is the outlet ;-). Cheers

jerryheir commented 4 years ago

Yeah I understand. Thanks for the reply

On Fri, Mar 27, 2020, 6:58 PM Mike Hardy notifications@github.com wrote:

Happy you took it that way, I realized after I typed it...it could go either way, but man I'm stuck in quarantine in my house 2 weeks and my family is tired of my terrible jokes, so I guess github is the outlet ;-). Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/invertase/react-native-firebase/issues/2842#issuecomment-605166035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDHZJ6XFC7QI46DV6TXUMTRJTSNLANCNFSM4JKWD3SA .