invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.7k stars 2.22k forks source link

UIWebView : [Admob] (Deprecated Api Usage) #2943

Closed yannou788 closed 4 years ago

yannou788 commented 4 years ago

Issue

"@react-native-firebase/admob": "6.1.0", TMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView.

After some research, I found that in RNFBAdMob.podspec there was an dependency with PersonalizedAdConsent (https://github.com/googleads/googleads-consent-sdk-ios/tree/master/PersonalizedAdConsent/PersonalizedAdConsent) which contains call to "UIWebView".


Project Files

iOS

Click To Expand

#### `ios/Podfile`: - [ ] I'm not using Pods - [x] I'm using Pods and my Podfile looks like: ```ruby # N/A ``` #### `AppDelegate.m`: ```objc // N/A ```


Android

Click To Expand

#### Have you converted to AndroidX? - [ ] my application is an AndroidX application? - [ ] I am using `android/gradle.settings` `jetifier=true` for Android compatibility? - [ ] I am using the NPM package `jetifier` for react-native compatibility? #### `android/build.gradle`: ```groovy // N/A ``` #### `android/app/build.gradle`: ```groovy // N/A ``` #### `android/settings.gradle`: ```groovy // N/A ``` #### `MainApplication.java`: ```java // N/A ``` #### `AndroidManifest.xml`: ```xml ```


Environment

Click To Expand

**`react-native info` output:** ``` OUTPUT GOES HERE ``` - **Platform that you're experiencing the issue on**: - [x ] iOS - [ ] Android - [ ] **iOS** but have not tested behavior on Android - [ ] **Android** but have not tested behavior on iOS - [ ] Both - **`react-native-firebase` version you're using that has this issue:** - `6.1.0` - **`Firebase` module(s) you're using that has the issue:** - `Admob` - **Are you using `TypeScript`?** - `N`


Think react-native-firebase is great? Please consider supporting all of the project maintainers and contributors by donating via our Open Collective where all contributors can submit expenses. [Learn More]

mikehardy commented 4 years ago

That's a google upstream bug. For v6 we need to change the issue template here as I need to see the contents of firebase.json to see if you are using the right versions - but I think this is unresolved anyway: https://github.com/googleads/googleads-consent-sdk-ios/issues/41 - follow along there and be prepared to do something like this when/if it is updated: https://github.com/mikehardy/rnfbdemo/blob/65a23cb22b4b91614746c1997f1bf83ca318016a/make-demo-v6.sh#L30

stale[bot] commented 4 years ago

Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

oidoug commented 4 years ago

Will this be retrofitted into v5? I'm not ready to jump to 6 yet and I'm having this issue.

Thanks!

mikehardy commented 4 years ago

RNFBv5 has no deprecated API usage if you use the up to date firebase SDKs, which you can safely use because I have already retrofitted all the necessary bits

I release to the Apple app store regularly with RNFBv5 + firebase iOS SDKs 6.14.0 (current) and itś fine.

oidoug commented 4 years ago

Oh my bad, I thought I was on the latest version. Thanks Mike!

rarira commented 4 years ago

if you use v6 and pod, please try to patch.. I successfully released app to app store. https://github.com/googleads/googleads-consent-sdk-ios/issues/41#issuecomment-560316564

mikehardy commented 4 years ago

Oh no - I did not realize there was another usage of UIWebView, thanks for that link @rarira - hopefully it is fixed upstream soon, in the meantime that comment has a great solution