invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.69k stars 2.21k forks source link

ECOMMERCE_PURCHASE event is deprecated in favor of PURCHASE event #3682

Closed bmamone closed 4 years ago

bmamone commented 4 years ago

Issue

According to Firebase docs, ECOMMERCE_PURCHASE event is deprecated and PURCHASE should be used instead, but it's not implemented in the analytics library.

This enables the user to log relevant parameters like items and should be updated before deprecation.


Project Files

Javascript

Click To Expand

#### `package.json`: ```json # N/A ``` #### `firebase.json` for react-native-firebase v6: ```json # N/A ```

iOS

Click To Expand

#### `ios/Podfile`: - [ ] I'm not using Pods - [x] I'm using Pods and my Podfile looks like: ```ruby # N/A ``` #### `AppDelegate.m`: ```objc // N/A ```


Android

Click To Expand

#### Have you converted to AndroidX? - [x] my application is an AndroidX application? - [x] I am using `android/gradle.settings` `jetifier=true` for Android compatibility? - [x] I am using the NPM package `jetifier` for react-native compatibility? #### `android/build.gradle`: ```groovy // N/A ``` #### `android/app/build.gradle`: ```groovy // N/A ``` #### `android/settings.gradle`: ```groovy // N/A ``` #### `MainApplication.java`: ```java // N/A ``` #### `AndroidManifest.xml`: ```xml ```


Environment

Click To Expand

**`react-native info` output:** ``` OUTPUT GOES HERE ``` - **Platform that you're experiencing the issue on**: - [ ] iOS - [ ] Android - [ ] **iOS** but have not tested behavior on Android - [x] **Android** but have not tested behavior on iOS - [ ] Both - **`react-native-firebase` version you're using that has this issue:** - 7.0.1 - **`Firebase` module(s) you're using that has the issue:** - Analytics - **Are you using `TypeScript`?** - No


Salakar commented 4 years ago

PR is in progress: https://github.com/invertase/react-native-firebase/pull/3385

This is also a duplicate of #3512 - closing as we're tracking there, thanks.