invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.68k stars 2.21k forks source link

The description InterstitialAd provokes a violation of admob rules #4099

Closed KVinS closed 4 years ago

KVinS commented 4 years ago

Documentation Feedback

Hello! Your example of using inter-screen advertising provokes violation of admob rules.

import { AdEventType } from '@react-native-firebase/admob';

interstitial.onAdEvent((type) => {
  if (type === AdEventType.LOADED) {
    interstitial.show();
  }
});

interstitial.load();

This is "Disallowed example: Interstitial launches after page load" in its pure form. 91E0E29ADFA1A1BF42097E0699CC491BE874

Or at least put a warning against showing ads immediately after loading. You'd better duplicate this example with tracking the load event.


mikehardy commented 4 years ago

@KVinS very interesting! The reference docs are built from the typings, but they are easily editable if you could propose a PR that would eliminate this risk for people?

I believe the relevant chunk starts right here and you just need to hit the "pencil" (edit) icon at top right to start https://github.com/invertase/react-native-firebase/blob/master/packages/admob/lib/index.d.ts#L932

stale[bot] commented 4 years ago

Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.