invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.68k stars 2.21k forks source link

RNFIREBASE Is not Making Document Node on Given Path throwing Error and making Orphaned Node of Documents #4280

Closed shtaimoortariq closed 4 years ago

shtaimoortariq commented 4 years ago

Issue

codeSnap

RN RNSNAP tempsnip tempsnip1

Describe your issue here I Am Using RNFIREBASE I have Collection of Files and there are Docs in the Files collection i want to make a Sub collection of Files on Selected Doc with Selected DocId But I Am Getting A Error DocumentPath Must Point At Document Even My Reference To That Document Is Valid with collection Name "files/docId" as you can see in Console.log() and on the Firebase Console the same Id Is Present Which i Gave to Make a SubCollection and make a Document Node On That DocumentNode but instead I Am Getting Error Of DocumentPath must Point At Document But its Making a SubCollection but With a New DocumentNode on Parent node Which is Orphaned.... Please Help me To Solve This Bug....

Project Files

Javascript

Click To Expand

#### `package.json`: { "name": "constructoapp", "version": "0.0.1", "private": true, "scripts": { "android": "react-native run-android", "ios": "react-native run-ios", "start": "react-native start", "test": "jest", "lint": "eslint ." }, "dependencies": { "@ant-design/react-native": "^4.0.2", "@react-native-community/async-storage": "^1.11.0", "@react-native-community/cameraroll": "^4.0.0", "@react-native-community/datetimepicker": "^2.6.0", "@react-native-community/masked-view": "^0.1.10", "@react-native-community/picker": "^1.6.6", "@react-native-community/segmented-control": "^2.1.1", "@react-native-community/slider": "^3.0.3", "@react-native-community/viewpager": "^4.1.0", "@react-native-firebase/analytics": "^7.6.1", "@react-native-firebase/app": "^8.4.1", "@react-native-firebase/auth": "^9.1.2", "@react-native-firebase/firestore": "^7.7.0", "@react-native-firebase/storage": "^7.4.2", "@react-navigation/bottom-tabs": "^5.6.1", "@react-navigation/material-top-tabs": "^5.2.13", "@react-navigation/native": "^5.7.0", "@react-navigation/stack": "^5.5.1", "jsrsasign": "^9.1.9", "jsrsasign-util": "^1.0.0", "md5": "^2.3.0", "moment": "^2.27.0", "native-base": "^2.13.12", "react": "16.11.0", "react-native": "0.62.2", "react-native-camera": "^3.36.0", "react-native-file-picker": "0.0.19", "react-native-flash-message": "^0.1.15", "react-native-geocoder": "^0.5.0", "react-native-geocoding": "^0.4.0", "react-native-geolocation-service": "^5.0.0", "react-native-gesture-handler": "^1.6.1", "react-native-image-crop-picker": "^0.33.2", "react-native-image-picker": "^2.3.3", "react-native-maps": "0.27.1", "react-native-modal": "^11.5.6", "react-native-modal-datetime-picker": "^8.7.1", "react-native-radio-buttons": "^1.0.0", "react-native-reanimated": "^1.9.0", "react-native-safe-area-context": "^3.0.3", "react-native-screens": "^2.8.0", "react-native-simple-crypto": "^0.2.13", "react-native-simple-radio-button": "^2.7.4", "react-native-svg": "^12.1.0", "react-native-svg-transformer": "^0.14.3", "react-native-swipeable": "^0.6.0", "react-native-tab-view": "^2.14.4", "react-native-vector-icons": "^6.6.0", "react-redux": "^7.2.0", "react-thunk": "^1.0.0", "redux": "^4.0.5", "redux-thunk": "^2.3.0", "rn-fetch-blob": "^0.12.0", "thunk": "0.0.1" }, "devDependencies": { "@babel/core": "^7.6.2", "@babel/runtime": "^7.6.2", "@react-native-community/eslint-config": "^0.0.5", "babel-jest": "^24.9.0", "eslint": "^6.5.1", "jest": "^24.9.0", "metro-react-native-babel-preset": "^0.58.0", "react-test-renderer": "16.11.0" }, "jest": { "preset": "react-native" } } ```json # N/A ``` #### `firebase.json` for react-native-firebase v6: ```json # N/A ```

iOS

Click To Expand

#### `ios/Podfile`: - [ ] I'm not using Pods - [x] I'm using Pods and my Podfile looks like: ```ruby # N/A ``` #### `AppDelegate.m`: ```objc // N/A ```


Android

Click To Expand

#### Have you converted to AndroidX? - [ ] my application is an AndroidX application? - [ ] I am using `android/gradle.settings` `jetifier=true` for Android compatibility? - [x ] I am using the NPM package `jetifier` for react-native compatibility? #### `android/build.gradle`: // Top-level build file where you can add configuration options common to all sub-projects/modules. buildscript { ext { buildToolsVersion = "28.0.3" minSdkVersion = 16 compileSdkVersion = 28 targetSdkVersion = 28 } repositories { google() jcenter() } dependencies { classpath("com.android.tools.build:gradle:3.5.2") classpath 'com.google.gms:google-services:4.3.3' // NOTE: Do not place your application dependencies here; they belong // in the individual module build.gradle files } } allprojects { repositories { mavenLocal() maven { // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm url("$rootDir/../node_modules/react-native/android") } maven { // Android JSC is installed from npm url("$rootDir/../node_modules/jsc-android/dist") } maven { url "https://maven.google.com" } google() jcenter() maven { url 'https://www.jitpack.io' } } } ```groovy // N/A ``` #### `android/app/build.gradle`: apply plugin: "com.android.application" import com.android.build.OutputFile /** * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets * and bundleReleaseJsAndAssets). * These basically call `react-native bundle` with the correct arguments during the Android build * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the * bundle directly from the development server. Below you can see all the possible configurations * and their defaults. If you decide to add a configuration block, make sure to add it before the * `apply from: "../../node_modules/react-native/react.gradle"` line. * * project.ext.react = [ * // the name of the generated asset file containing your JS bundle * bundleAssetName: "index.android.bundle", * * // the entry file for bundle generation. If none specified and * // "index.android.js" exists, it will be used. Otherwise "index.js" is * // default. Can be overridden with ENTRY_FILE environment variable. * entryFile: "index.android.js", * * // https://facebook.github.io/react-native/docs/performance#enable-the-ram-format * bundleCommand: "ram-bundle", * * // whether to bundle JS and assets in debug mode * bundleInDebug: false, * * // whether to bundle JS and assets in release mode * bundleInRelease: true, * * // whether to bundle JS and assets in another build variant (if configured). * // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants * // The configuration property can be in the following formats * // 'bundleIn${productFlavor}${buildType}' * // 'bundleIn${buildType}' * // bundleInFreeDebug: true, * // bundleInPaidRelease: true, * // bundleInBeta: true, * * // whether to disable dev mode in custom build variants (by default only disabled in release) * // for example: to disable dev mode in the staging build type (if configured) * devDisabledInStaging: true, * // The configuration property can be in the following formats * // 'devDisabledIn${productFlavor}${buildType}' * // 'devDisabledIn${buildType}' * * // the root of your project, i.e. where "package.json" lives * root: "../../", * * // where to put the JS bundle asset in debug mode * jsBundleDirDebug: "$buildDir/intermediates/assets/debug", * * // where to put the JS bundle asset in release mode * jsBundleDirRelease: "$buildDir/intermediates/assets/release", * * // where to put drawable resources / React Native assets, e.g. the ones you use via * // require('./image.png')), in debug mode * resourcesDirDebug: "$buildDir/intermediates/res/merged/debug", * * // where to put drawable resources / React Native assets, e.g. the ones you use via * // require('./image.png')), in release mode * resourcesDirRelease: "$buildDir/intermediates/res/merged/release", * * // by default the gradle tasks are skipped if none of the JS files or assets change; this means * // that we don't look at files in android/ or ios/ to determine whether the tasks are up to * // date; if you have any other folders that you want to ignore for performance reasons (gradle * // indexes the entire tree), add them here. Alternatively, if you have JS files in android/ * // for example, you might want to remove it from here. * inputExcludes: ["android/**", "ios/**"], * * // override which node gets called and with what additional arguments * nodeExecutableAndArgs: ["node"], * * // supply additional arguments to the packager * extraPackagerArgs: [] * ] */ project.ext.react = [ enableHermes: false, // clean and rebuild if changing ] apply from: "../../node_modules/react-native/react.gradle" /** * Set this to true to create two separate APKs instead of one: * - An APK that only works on ARM devices * - An APK that only works on x86 devices * The advantage is the size of the APK is reduced by about 4MB. * Upload all the APKs to the Play Store and people will download * the correct one based on the CPU architecture of their device. */ def enableSeparateBuildPerCPUArchitecture = false /** * Run Proguard to shrink the Java bytecode in release builds. */ def enableProguardInReleaseBuilds = false /** * The preferred build flavor of JavaScriptCore. * * For example, to use the international variant, you can use: * `def jscFlavor = 'org.webkit:android-jsc-intl:+'` * * The international variant includes ICU i18n library and necessary data * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that * give correct results when using with locales other than en-US. Note that * this variant is about 6MiB larger per architecture than default. */ def jscFlavor = 'org.webkit:android-jsc:+' /** * Whether to enable the Hermes VM. * * This should be set on project.ext.react and mirrored here. If it is not set * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode * and the benefits of using Hermes will therefore be sharply reduced. */ def enableHermes = project.ext.react.get("enableHermes", false); android { compileSdkVersion rootProject.ext.compileSdkVersion dexOptions { javaMaxHeapSize "4g" } compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 targetCompatibility JavaVersion.VERSION_1_8 } defaultConfig { applicationId "com.constructoapp" minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion versionCode 1 versionName "1.0" multiDexEnabled true missingDimensionStrategy 'react-native-camera', 'general' // <--- insert this line } splits { abi { reset() enable enableSeparateBuildPerCPUArchitecture universalApk false // If true, also generate a universal APK include "armeabi-v7a", "x86", "arm64-v8a", "x86_64" } } signingConfigs { debug { storeFile file('debug.keystore') storePassword 'android' keyAlias 'androiddebugkey' keyPassword 'android' } } buildTypes { debug { signingConfig signingConfigs.debug } release { signingConfig signingConfigs.debug minifyEnabled enableProguardInReleaseBuilds proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" } } packagingOptions { pickFirst "lib/armeabi-v7a/libc++_shared.so" pickFirst "lib/arm64-v8a/libc++_shared.so" pickFirst "lib/x86/libc++_shared.so" pickFirst "lib/x86_64/libc++_shared.so" } // applicationVariants are e.g. debug, release applicationVariants.all { variant -> variant.outputs.each { output -> // For each separate APK per architecture, set a unique version code as described here: // https://developer.android.com/studio/build/configure-apk-splits.html def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4] def abi = output.getFilter(OutputFile.ABI) if (abi != null) { // null for the universal-debug, universal-release variants output.versionCodeOverride = versionCodes.get(abi) * 1048576 + defaultConfig.versionCode } } } } dependencies { implementation fileTree(dir: "libs", include: ["*.jar"]) //noinspection GradleDynamicVersion implementation project(':react-native-vector-icons') implementation "com.facebook.react:react-native:+" // From node_modules implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0" debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") { exclude group:'com.facebook.fbjni' } debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } if (enableHermes) { def hermesPath = "../../node_modules/hermes-engine/android/"; debugImplementation files(hermesPath + "hermes-debug.aar") releaseImplementation files(hermesPath + "hermes-release.aar") } else { implementation jscFlavor } } // Run this once to be able to run the application with BUCK // puts all compile dependencies into folder libs for BUCK to use task copyDownloadableDepsToLibs(type: Copy) { from configurations.compile into 'libs' } apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) apply plugin: 'com.google.gms.google-services' ```groovy // N/A ``` #### `android/settings.gradle`: rootProject.name = 'constructoapp' apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) include ':app' include ':react-native-vector-icons' project(':react-native-vector-icons').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-vector-icons/android') ```groovy // N/A ``` #### `MainApplication.java`: package com.constructoapp; import android.app.Application; import android.content.Context; import com.facebook.react.PackageList; import com.facebook.react.ReactApplication; import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactNativeHost; import com.facebook.react.ReactPackage; import com.facebook.soloader.SoLoader; import java.lang.reflect.InvocationTargetException; import java.util.List; public class MainApplication extends Application implements ReactApplication { private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) { @Override public boolean getUseDeveloperSupport() { return BuildConfig.DEBUG; } @Override protected List getPackages() { @SuppressWarnings("UnnecessaryLocalVariable") List packages = new PackageList(this).getPackages(); // Packages that cannot be autolinked yet can be added manually here, for // example: // packages.add(new MyReactNativePackage()); return packages; } @Override protected String getJSMainModuleName() { return "index"; } }; @Override public ReactNativeHost getReactNativeHost() { return mReactNativeHost; } @Override public void onCreate() { super.onCreate(); SoLoader.init(this, /* native exopackage */ false); initializeFlipper(this, getReactNativeHost().getReactInstanceManager()); } /** * Loads Flipper in React Native templates. Call this in the onCreate method * with something like initializeFlipper(this, * getReactNativeHost().getReactInstanceManager()); * * @param context * @param reactInstanceManager */ private static void initializeFlipper(Context context, ReactInstanceManager reactInstanceManager) { if (BuildConfig.DEBUG) { try { /* * We use reflection here to pick up the class that initializes Flipper, since * Flipper library is not available in release mode */ Class aClass = Class.forName("com.constructoapp.ReactNativeFlipper"); aClass.getMethod("initializeFlipper", Context.class, ReactInstanceManager.class).invoke(null, context, reactInstanceManager); } catch (ClassNotFoundException e) { e.printStackTrace(); } catch (NoSuchMethodException e) { e.printStackTrace(); } catch (IllegalAccessException e) { e.printStackTrace(); } catch (InvocationTargetException e) { e.printStackTrace(); } } } } ```java // N/A ``` #### `AndroidManifest.xml`: ```xml ```


Environment

Click To Expand

**`react-native info` output:** ``` OUTPUT GOES HERE ``` - **Platform that you're experiencing the issue on**: - [ ] iOS - [x] Android - [ ] **iOS** but have not tested behavior on Android - [x] **Android** but have not tested behavior on iOS - [ ] Both - **`react-native-firebase` version you're using that has this issue:** - `e.g. 5.4.3` - **`Firebase` module(s) you're using that has the issue:** - `e.g. Instance ID` - **Are you using `TypeScript`?** - `Y/N` & `VERSION`


mikehardy commented 4 years ago

I was explicit that images are terrible for debugging. Could you not post text? Copy + paste the important bits inside triple-backticks? This issue is frankly insufferable to read, I will not take the time to parse it out.

Provide an App.js that minimally reproduces the problem and we can investigate.

shtaimoortariq commented 4 years ago

@mikehardy what you want how do i describe ? i am giving a path to the db.doc(/files/doc.id).collection("files").doc() the doc.id is i am providing which is valid and have a documentnode in firebase still its giving me error that DocumentPath is not valid and throwing error but it made a orphaned node on the root of the collection with sub collection which i wanted to make but in that reference document. but it made it on root

shtaimoortariq commented 4 years ago

the whole thing is by providing it a valid path it doesnt get the Document on that path throwing error and making a new orphaned documentNode on root of the collection with orphaned documentNode with Subcollection. i wanted subCollection on provided DocumentId but unfortunatelly its making a orphaned node on root

mikehardy commented 4 years ago

@shtaimoortariq this is an open source project. You're asking for help from random people on the internet.

So, you are on the street, enjoying a coffee. A line of people forms. They all ask you for help. In the line is some person you have never met when it's his turn, he asks for your help, shows you two pictures with no information.

What do you do?

What I do is say: hey there! We've got a form that requests all the information we normally need. And your problem looks pretty project-specific. In fact, no one else has this problem. So we would like an App.js that we can drop in an existing project we use for troubleshooting, then we can reproduce it and see how it goes.

I am not going to do your troubleshooting work for you in other words. You are going to provide what we need because you are asking for help

shtaimoortariq commented 4 years ago

okay here you go App.js file

shtaimoortariq commented 4 years ago
import React from 'react';
import {
  SafeAreaView,
  StyleSheet,
  ScrollView,
  View,
  Text,
  StatusBar,
  Platform,
} from 'react-native';
import Navigations from './src/Navigation/StackNavigator';
import Geocoder from 'react-native-geocoding';
import firestore from '@react-native-firebase/firestore';
import FlashMessage from 'react-native-flash-message';
import {CurrentUser} from './Store/Action/Users';
import {getProject} from './Store/Action/ActionCreator';
import {useDispatch, useSelector} from 'react-redux';

const App = () => {
  const userData = useSelector(state => state.User.CurrentUser);
  const {projectId} = userData;
  console.log(userData, 'projectID ');
  let dispatch = useDispatch();
  React.useEffect(() => {
    if (projectId) {
      dispatch(getProject(projectId));
    }
  }, [projectId]);
  React.useEffect(() => {
    bootstrap();
    dispatch(CurrentUser());
  }, []);
  async function bootstrap() {
    await firestore().settings({
      persistence: true, // disable offline persistence
    });
  }
  return (
    <View style={{flex: 1}}>
      <Navigations />
      <FlashMessage position="top" />
    </View>
  );
};

export default App;
mikehardy commented 4 years ago

I don't see a single firebase collection, ref, data() or set i nthere at all?

This generates a completely empty example project: https://github.com/mikehardy/rnfbdemo/blob/master/make-demo.sh

If I were to drop this App.js in there, it would not run. It would show me nothing, and not reproduce your issue

Remember, I do not have your project, I am just some guy in the internet. I have test harnesses and example projects but they are clean and empty on purpose so I get clean reproductions.

I will drop the App.js you provide into an empty clean harness, and it needs to show the problem.