search

invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.7k stars 2.22k forks source link

Extend Sign in with Apple OAuth Provider - add ability to set full name #7603

Open mikehardy opened 9 months ago

mikehardy commented 9 months ago

With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7

The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk

Likely location to add new parameter for the full name in the Apple OAuth credential creation:

https://github.com/invertase/react-native-firebase/blob/ff32fd37b39557e9a55fce016cbf986348436b92/packages/auth/lib/providers/AppleAuthProvider.js#L29-L34

Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here https://github.com/firebase/firebase-ios-sdk/issues/4393#issuecomment-1478733407:

https://github.com/invertase/react-native-firebase/blob/ff32fd37b39557e9a55fce016cbf986348436b92/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L1349-L1351

PRs welcome! Confirmed that it is tested and working locally critical...

As mentioned in #4046

Claeysson commented 9 months ago

This is an essential feature since Apple rejects apps that don't set the user name based on what is provided by the Apple authentication process.

mikehardy commented 9 months ago

Hi there! In an open source contexts, essential features that are important to you may be implemented at any time via a pull request - I review them all and merge everything that looks good as fast as possible with quick releases

Otherwise, you'll have to be patient and hope some kind fellow developer implements the thing you need, but that will not be in your control

github-actions[bot] commented 8 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

siquick commented 6 months ago

This would be a great addition to the library.

github-actions[bot] commented 3 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] commented 2 months ago

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

thanhnd1o2 commented 1 week ago

i have the same issue