search

invertase / react-native-firebase

🔥 A well-tested feature-rich modular Firebase implementation for React Native. Supports both iOS & Android platforms for all Firebase services.
https://rnfirebase.io
Other
11.72k stars 2.22k forks source link

refactor: de-duplicate deprecation warning calls and tests #8135

Closed mikehardy closed 1 week ago

mikehardy commented 1 week ago

A quick take on reducing boilerplate - I wasn't sure it would even work so it was easier to just try it vs try to explain it, since if it didn't work it wasn't worth explaining but the code itself was just the work of a few minutes

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:21pm
mikehardy commented 1 week ago

I did a positive / negative visual test on this to make sure I wasn't lying to myself and if I specifically broke the test by calling deprecated in non-deprecated slot, or calling non-deprecated in deprecated slot it did trigger failures as expected