invertase / react-native-google-mobile-ads

React Native Google Mobile Ads enables you to monetize your app with AdMob.
https://docs.page/invertase/react-native-google-mobile-ads
Other
672 stars 135 forks source link

[🐛] Help to fix android error #117

Closed devGuerra closed 2 years ago

devGuerra commented 2 years ago

Issue

Help to fix this issue in android build

package io.invertase.googlemobileads does not exist

/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:33: error: package io.invertase.googlemobileads does not exist
import io.invertase.googlemobileads.ReactNativeGoogleMobileAdsPackage;
                                   ^
/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:100: error: cannot find symbol
      new ReactNativeGoogleMobileAdsPackage(),
          ^
  symbol:   class ReactNativeGoogleMobileAdsPackage
  location: class PackageList
Note: /android/app/src/debug/java/com/mobird/gruposlink/ReactNativeFlipper.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors

Project Files

Javascript

Click To Expand

#### `package.json`: ```json { "main": "index.js", "scripts": { "android": "react-native run-android", "ios": "react-native run-ios", "web": "expo start --web", "start": "react-native start", "clean:android": "watchman watch-del-all echo watchman && rm -f yarn.lock && rm -rf node_modules && yarn" }, "dependencies": { "@expo-google-fonts/poppins": "^0.2.0", "@expo/vector-icons": "^12.0.0", "@hookform/resolvers": "^2.8.0", "@react-native-async-storage/async-storage": "~1.15.0", "@react-native-clipboard/clipboard": "^1.8.5", "@react-native-firebase/analytics": "^14.8.0", "@react-native-firebase/app": "^14.8.0", "@react-native-firebase/firestore": "^14.8.0", "@react-navigation/bottom-tabs": "^6.0.7", "@react-navigation/native": "^6.0.4", "@react-navigation/native-stack": "^6.2.2", "@react-navigation/stack": "^6.0.9", "axios": "^0.21.4", "babel-plugin-inline-dotenv": "^1.6.0", "babel-plugin-transform-inline-environment-variables": "^0.4.3", "dotenv": "^10.0.0", "expo": "^43.0.0", "expo-app-loading": "~1.2.1", "expo-apple-authentication": "~4.0.3", "expo-asset": "~8.4.3", "expo-auth-session": "~3.4.2", "expo-constants": "~12.1.3", "expo-font": "~10.0.3", "expo-google-sign-in": "~10.0.3", "expo-in-app-purchases": "~12.0.0", "expo-linear-gradient": "~10.0.3", "expo-linking": "~2.4.2", "expo-random": "~12.0.1", "expo-splash-screen": "~0.13.5", "expo-status-bar": "~1.1.0", "expo-store-review": "~5.0.3", "expo-updates": "~0.10.15", "font-color-contrast": "^1.1.1", "install": "^0.13.0", "intl": "^1.2.5", "lottie-ios": "3.2.3", "lottie-react-native": "^4.1.3", "npm": "^7.24.1", "react": "17.0.1", "react-dom": "17.0.1", "react-hook-form": "^7.15.3", "react-input-mask": "^2.0.4", "react-native": "0.64.3", "react-native-chart-kit": "^6.11.0", "react-native-collapsible": "^1.6.0", "react-native-country-flag": "^1.1.4", "react-native-dotenv": "^3.2.0", "react-native-dropdown-picker": "^5.2.3", "react-native-gesture-handler": "~1.10.2", "react-native-google-mobile-ads": "^5.1.1", "react-native-iphone-x-helper": "^1.3.1", "react-native-mask-text": "^0.5.0", "react-native-modal": "^13.0.0", "react-native-onesignal": "^4.3.1", "react-native-reanimated": "~2.2.0", "react-native-responsive-fontsize": "^0.5.1", "react-native-safe-area-context": "3.3.2", "react-native-screens": "~3.8.0", "react-native-skeleton-content": "^1.0.22", "react-native-status-bar-height": "^2.6.0", "react-native-svg": "12.1.1", "react-native-svg-transformer": "^0.14.3", "react-native-table-component": "^1.2.1", "react-native-web": "0.17.1", "react-native-webview": "11.13.0", "styled-components": "^5.3.1", "yup": "^0.32.9" }, "devDependencies": { "@babel/core": "^7.12.9", "@types/react": "~17.0.21", "@types/react-native": "~0.64.12", "@types/react-native-table-component": "^1.2.3", "@types/react-native-vector-icons": "^6.4.9", "@types/styled-components-react-native": "^5.1.1", "typescript": "~4.3.5" }, "private": true, "name": "ipvacarro", "version": "5.9.0" } ``` #### `admob.json`: ```json # N/A ```

Android

Click To Expand

#### `android/build.gradle`: ```groovy // Top-level build file where you can add configuration options common to all sub-projects/modules. buildscript { ext { buildToolsVersion = "30.0.2" minSdkVersion = 21 compileSdkVersion = 31 targetSdkVersion = 31 } repositories { gradlePluginPortal() google() mavenCentral() jcenter() } dependencies { classpath("com.android.tools.build:gradle:4.1.0") classpath 'com.google.gms:google-services:4.3.5' classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.12.10, 0.99.99]' // NOTE: Do not place your application dependencies here; they belong // in the individual module build.gradle files } } allprojects { repositories { mavenLocal() maven { // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm url(new File(["node", "--print", "require.resolve('react-native/package.json')"].execute().text.trim(), "../android")) } maven { // Android JSC is installed from npm url(new File(["node", "--print", "require.resolve('jsc-android/package.json')"].execute().text.trim(), "../dist")) } google() mavenCentral() jcenter() maven { url 'https://www.jitpack.io' } } } ``` #### `android/app/build.gradle`: ```groovy apply plugin: "com.android.application" import com.android.build.OutputFile /** * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets * and bundleReleaseJsAndAssets). * These basically call `react-native bundle` with the correct arguments during the Android build * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the * bundle directly from the development server. Below you can see all the possible configurations * and their defaults. If you decide to add a configuration block, make sure to add it before the * `apply from: "../../node_modules/react-native/react.gradle"` line. * * project.ext.react = [ * // the name of the generated asset file containing your JS bundle * bundleAssetName: "index.android.bundle", * * // the entry file for bundle generation. If none specified and * // "index.android.js" exists, it will be used. Otherwise "index.js" is * // default. Can be overridden with ENTRY_FILE environment variable. * entryFile: "index.android.js", * * // https://reactnative.dev/docs/performance#enable-the-ram-format * bundleCommand: "ram-bundle", * * // whether to bundle JS and assets in debug mode * bundleInDebug: false, * * // whether to bundle JS and assets in release mode * bundleInRelease: true, * * // whether to bundle JS and assets in another build variant (if configured). * // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants * // The configuration property can be in the following formats * // 'bundleIn${productFlavor}${buildType}' * // 'bundleIn${buildType}' * // bundleInFreeDebug: true, * // bundleInPaidRelease: true, * // bundleInBeta: true, * * // whether to disable dev mode in custom build variants (by default only disabled in release) * // for example: to disable dev mode in the staging build type (if configured) * devDisabledInStaging: true, * // The configuration property can be in the following formats * // 'devDisabledIn${productFlavor}${buildType}' * // 'devDisabledIn${buildType}' * * // the root of your project, i.e. where "package.json" lives * root: "../../", * * // where to put the JS bundle asset in debug mode * jsBundleDirDebug: "$buildDir/intermediates/assets/debug", * * // where to put the JS bundle asset in release mode * jsBundleDirRelease: "$buildDir/intermediates/assets/release", * * // where to put drawable resources / React Native assets, e.g. the ones you use via * // require('./image.png')), in debug mode * resourcesDirDebug: "$buildDir/intermediates/res/merged/debug", * * // where to put drawable resources / React Native assets, e.g. the ones you use via * // require('./image.png')), in release mode * resourcesDirRelease: "$buildDir/intermediates/res/merged/release", * * // by default the gradle tasks are skipped if none of the JS files or assets change; this means * // that we don't look at files in android/ or ios/ to determine whether the tasks are up to * // date; if you have any other folders that you want to ignore for performance reasons (gradle * // indexes the entire tree), add them here. Alternatively, if you have JS files in android/ * // for example, you might want to remove it from here. * inputExcludes: ["android/**", "ios/**"], * * // override which node gets called and with what additional arguments * nodeExecutableAndArgs: ["node"], * * // supply additional arguments to the packager * extraPackagerArgs: [] * ] */ project.ext.react = [ enableHermes: (findProperty('expo.jsEngine') ?: "jsc") == "hermes", cliPath: new File(["node", "--print", "require.resolve('react-native/package.json')"].execute().text.trim(), "../cli.js"), ] apply from: new File(["node", "--print", "require.resolve('react-native/package.json')"].execute().text.trim(), "../react.gradle") /** * Set this to true to create two separate APKs instead of one: * - An APK that only works on ARM devices * - An APK that only works on x86 devices * The advantage is the size of the APK is reduced by about 4MB. * Upload all the APKs to the Play Store and people will download * the correct one based on the CPU architecture of their device. */ def enableSeparateBuildPerCPUArchitecture = false /** * Run Proguard to shrink the Java bytecode in release builds. */ def enableProguardInReleaseBuilds = false /** * The preferred build flavor of JavaScriptCore. * * For example, to use the international variant, you can use: * `def jscFlavor = 'org.webkit:android-jsc-intl:+'` * * The international variant includes ICU i18n library and necessary data * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that * give correct results when using with locales other than en-US. Note that * this variant is about 6MiB larger per architecture than default. */ def jscFlavor = 'org.webkit:android-jsc:+' /** * Whether to enable the Hermes VM. * * This should be set on project.ext.react and mirrored here. If it is not set * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode * and the benefits of using Hermes will therefore be sharply reduced. */ def enableHermes = project.ext.react.get("enableHermes", false); android { compileSdkVersion rootProject.ext.compileSdkVersion compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 targetCompatibility JavaVersion.VERSION_1_8 } defaultConfig { applicationId 'com.mobird.ipvacarro' minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion versionCode 5100 versionName "5.10.0" } splits { abi { reset() enable enableSeparateBuildPerCPUArchitecture universalApk false // If true, also generate a universal APK include "armeabi-v7a", "x86", "arm64-v8a", "x86_64" } } signingConfigs { debug { storeFile file('debug.keystore') storePassword 'android' keyAlias 'androiddebugkey' keyPassword 'android' } } buildTypes { debug { signingConfig signingConfigs.debug } release { // Caution! In production, you need to generate your own keystore file. // see https://reactnative.dev/docs/signed-apk-android. signingConfig signingConfigs.debug minifyEnabled enableProguardInReleaseBuilds proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" } } // applicationVariants are e.g. debug, release applicationVariants.all { variant -> variant.outputs.each { output -> // For each separate APK per architecture, set a unique version code as described here: // https://developer.android.com/studio/build/configure-apk-splits.html def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4] def abi = output.getFilter(OutputFile.ABI) if (abi != null) { // null for the universal-debug, universal-release variants output.versionCodeOverride = versionCodes.get(abi) * 1048576 + defaultConfig.versionCode } } } } dependencies { implementation fileTree(dir: "libs", include: ["*.jar"]) //noinspection GradleDynamicVersion implementation "com.facebook.react:react-native:+" // From node_modules def isGifEnabled = (findProperty('expo.gif.enabled') ?: "") == "true"; def isWebpEnabled = (findProperty('expo.webp.enabled') ?: "") == "true"; def isWebpAnimatedEnabled = (findProperty('expo.webp.animated') ?: "") == "true"; // If your app supports Android versions before Ice Cream Sandwich (API level 14) // All fresco packages should use the same version if (isGifEnabled || isWebpEnabled) { implementation 'com.facebook.fresco:fresco:2.0.0' implementation 'com.facebook.fresco:imagepipeline-okhttp3:2.0.0' } if (isGifEnabled) { // For animated gif support implementation 'com.facebook.fresco:animated-gif:2.0.0' } if (isWebpEnabled) { // For webp support implementation 'com.facebook.fresco:webpsupport:2.0.0' if (isWebpAnimatedEnabled) { // Animated webp support implementation 'com.facebook.fresco:animated-webp:2.0.0' } } implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0" debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") { exclude group:'com.facebook.fbjni' } debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' exclude group:'com.squareup.okhttp3', module:'okhttp' } debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } if (enableHermes) { debugImplementation files(new File(["node", "--print", "require.resolve('hermes-engine/package.json')"].execute().text.trim(), "../android/hermes-debug.aar")) releaseImplementation files(new File(["node", "--print", "require.resolve('hermes-engine/package.json')"].execute().text.trim(), "../android/hermes-release.aar")) } else { implementation jscFlavor } } // Run this once to be able to run the application with BUCK // puts all compile dependencies into folder libs for BUCK to use task copyDownloadableDepsToLibs(type: Copy) { from configurations.compile into 'libs' } apply plugin: 'com.google.gms.google-services' apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin' apply from: new File(["node", "--print", "require.resolve('@react-native-community/cli-platform-android/package.json')"].execute().text.trim(), "../native_modules.gradle"); applyNativeModulesAppBuildGradle(project) ``` #### `android/settings.gradle`: ```groovy rootProject.name = 'appcarro' apply from: new File(["node", "--print", "require.resolve('expo/package.json')"].execute().text.trim(), "../scripts/autolinking.gradle"); useExpoModules() apply from: new File(["node", "--print", "require.resolve('@react-native-community/cli-platform-android/package.json')"].execute().text.trim(), "../native_modules.gradle"); applyNativeModulesSettingsGradle(settings) include ':app' ``` #### `AndroidManifest.xml`: ```xml ```


Environment

Click To Expand

**`react-native info` output:** ``` OUTPUT GOES HERE ``` - **Platform that you're experiencing the issue on**: - [ ] iOS - [x] Android - [ ] **iOS** but have not tested behavior on Android - [ ] **Android** but have not tested behavior on iOS - [ ] Both - **Are you using `TypeScript`?** - `Y` & `~4.3.5`


mikehardy commented 2 years ago

Unfortunately I'm not sure what we can do here, there is an incorrect project integration of some sort, additionally react-native 0.64 is quite old, I'm not sure we'll be 100% compatible with it (there are, for example, EventEmitter problems with versions that old in some other modules I work on, as there was a change to EventEmitter in react-native internals in 0.65 that modules had to adapt to)

Since there are so many ways a project integration can fail, and they take so much maintainer time that can be used for other things, I no longer attempt to diagnose them.

Instead I provide a fully-scripted "let's get mobile ads working from scratch" script that we actually use to build our example app.

You run it, it works, and it shows that the integration can work. Unfortunately, determining exactly why your specific project is not working is an exercise for each project

https://github.com/invertase/react-native-google-mobile-ads/blob/main/refresh-example.sh

It constitutes a https://stackoverflow.com/help/minimal-reproducible-example of success and is sufficient to close this, though I do of course hope you find the problem, and if there's anything to learn we can certainly discuss - maybe some documentation changes or similar are needed ?

devGuerra commented 2 years ago

Hy @mikehardy I managed to solve it

Just needed to move react-native-google-mobile-ads in app.son to out of the expo object and run expo run:android rather than react-native run-android

mikehardy commented 2 years ago

Oh fantastic! Happy to hear you got it working. Good luck with your project