invertase / react-native-google-mobile-ads

React Native Google Mobile Ads enables you to monetize your app with AdMob.
https://docs.page/invertase/react-native-google-mobile-ads
Other
625 stars 121 forks source link

docs(ios): note that pod install is required to see ios_config.sh changes #550

Closed mikehardy closed 4 months ago

mikehardy commented 4 months ago

Description

This wastes developer's time, we should warn them

Related issues

Related:

Release Summary

docs only, no release

Checklist

Test Plan

No tests needed, all comments


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

codecov[bot] commented 4 months ago

Codecov Report

Merging #550 (f7bee6c) into main (7aef863) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ======================================= Coverage 43.66% 43.66% ======================================= Files 29 29 Lines 536 536 Branches 147 147 ======================================= Hits 234 234 Misses 302 302 ```
mikehardy commented 4 months ago

This is in place in react-native-firebase, no issues

mikehardy commented 4 months ago

(it will trigger a project.pbxproj change in the example project on next example project pod install)

mikehardy commented 3 months ago

:tada: This PR is included in version 13.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: