invertase / react-native-google-mobile-ads

React Native Google Mobile Ads enables you to monetize your app with AdMob.
https://docs.page/invertase/react-native-google-mobile-ads
Other
625 stars 121 forks source link

fix(android): forward port onAdLoaded signature for Kotlin 1.9 #560

Closed YannickBruening closed 2 months ago

YannickBruening commented 3 months ago

Description

I was unable to build this and nobody else wanted to make a PR in the issue. I hope this resolves that issue. But the change has worked for me.

This PR fixes the android build issue: ReactNativeGoogleMobileAdsFullScreenAdModule.kt 'onAdLoaded' overrides nothing

Related issues

511

Release Summary

Checklist

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

YannickBruening commented 3 months ago

If the force push should be a problem for you I have no problem with recreating the pr with another non force-pushed branch. :) Force was done with '--force-with-lease'

codecov[bot] commented 2 months ago

Codecov Report

Merging #560 (5261681) into main (8dd5b93) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #560 +/- ## ======================================= Coverage 43.66% 43.66% ======================================= Files 29 29 Lines 536 536 Branches 147 147 ======================================= Hits 234 234 Misses 302 302 ```
mikehardy commented 2 months ago

It passed android build with react-native 0.72 in use and kotlin 1.7.x so I'm going to call this backwards compatible! No worries about compatibility I can see then - hopefully not famous last words

mikehardy commented 2 months ago

:tada: This PR is included in version 13.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: