fix(banner, ios): fixed memory leak - Githubissues

invertase / react-native-google-mobile-ads

React Native Google Mobile Ads enables you to monetize your app with AdMob.

https://docs.page/invertase/react-native-google-mobile-ads

Other

625 stars 121 forks source link

fix(banner, ios): fixed memory leak #565

Closed birdofpreyru closed 1 month ago

birdofpreyru commented 2 months ago

Description

Related issues

https://github.com/invertase/react-native-google-mobile-ads/issues/496

Release Summary

Fixes memory leak when using banners on iOS with old RN architecture.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] Yes
My change supports the following platforms;
- [ ] Android
- [x] iOS
My change includes tests;
- [ ] e2e tests added or updated in __tests__e2e__
- [ ] jest tests added or updated in __tests__
[ ] I have updated TypeScript types that are affected by my change.
This is a breaking change;
- [ ] Yes
- [x] No

Test Plan

Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow Invertase on Twitter

dylancom commented 2 months ago

Thanks for the investigation and PR. I also pushed a fix for banners in the new arch.

mikehardy commented 1 month ago

:tada: This PR is included in version 13.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: