test(ci): various fixes to get CI green

invertase / react-native-google-mobile-ads

React Native Google Mobile Ads enables you to monetize your app with AdMob.

https://docs.page/invertase/react-native-google-mobile-ads

Other

625 stars 121 forks source link

test(ci): various fixes to get CI green #582

Closed mikehardy closed 1 month ago

mikehardy commented 1 month ago

Just some patches + fixes to get CI going ✅

mikehardy commented 1 month ago

think I got everything going here / all entropy reversed except jest, it fails locally for me as well

dylancom commented 1 month ago

Great work! Do you think you can fix the failing related to "jet"?

mikehardy commented 1 month ago

I don't recall seeing anything jet-related, do you mean jest?

dylancom commented 1 month ago

Locally it fails over:

react-native-google-mobile-ads/RNGoogleMobileAdsExample/node_modules/jet/dist/TestContainer.js:168 resultText.push( ^

SyntaxError: Unexpected token '<'

mikehardy commented 1 month ago

Took another cut at it - I'm honestly not sure what value the jest testing provides here, and I'm a huge fan of testing - just this area is pretty difficult

Anyway, in the latest push I:

cleaned up the last (I hope) deprecation errors on an an action I forgot (linting)
noticed the linting was totally broken so updated react-native dev-dep, forward-ported typings, fixed the lint report task etc
cleaned up the patch-package contents generation as it had some files in there that shouldn't be in there. NOTE - the files are in there because the files section of package.json / .npmignore combination is generating a bloated npm package and that needs examination

mikehardy commented 1 month ago

Not sure I'll have time to complete whatever is required to fix jest and I humbly submit that this PR has enough value as is to go in, as it is definitely an incremental improvement over current situation where CI has near zero signalling value, and I'm not sure what the value of the jest tests are...

dylancom commented 1 month ago

Thanks for the great work! I just pushed a small commit which fixes jest :) All green again 🎉🎉

mikehardy commented 4 weeks ago

Yes! Mission Accomplished :-)