fix(android): Fixed map the commands

minhchienwikipedia commented 5 days ago

Description

Seems you guys missing to convert the commands from string to number, I just added changes to fix it and make some function triggers by command work.

Related issues

Release Summary

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ x] Yes
My change supports the following platforms;
- [x ] Android
- [ ] iOS
My change includes tests;
- [ x] e2e tests added or updated in __tests__e2e__
- [ x] jest tests added or updated in __tests__
[ ]x I have updated TypeScript types that are affected by my change.
This is a breaking change;
- [ x] Yes
- [ ] No

Test Plan

Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow Invertase on Twitter

CLAassistant commented 5 days ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dylancom commented 2 days ago

The string is already parsed to an integer so I don't understand what this fixes. Integer.parseInt(commandId)

This could be made redundant by changing the parameter directly to int commandId.

minhchienwikipedia commented 2 days ago

@dylancom the commandId is "load", "recordManualImpression" -> so it can't be parseInt, you can try to test it you will get the error. So I think you guys are missing the map command string to the command number. I had tested it and it works for me

dylancom commented 2 days ago

Hmm I see it's broken now in our example app. Might be related to the new arch.

dylancom commented 1 day ago

I'm currently on a holiday so I don't have time to test this thoroughly on both archs. @mikehardy / others? 👀

invertase / react-native-google-mobile-ads