Open Ehesp opened 8 years ago
Anything more planned for 0.4.0, that I can take up? I guess you are handling the List Refactor.
The GridComponent? Also I need to debug a Ripple bug where the state persists. Any other ideas I'm open to!
What about a FAB?
Ah yeah. How should the position of it be done? Simply render the FAB and let the user decide where to place it? On 5 Jan 2016 9:00 p.m., "David Gil" notifications@github.com wrote:
What about a FAB?
— Reply to this email directly or view it on GitHub https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169132655 .
Hmm not really sure. Specs about fabs say how they should be positioned with relation to other objects, and they seem to be always bottom-right ... Maybe we can style them lime that by default and let the user override?
El mar, 5 de enero de 2016 22:02, Elliot Hesp notifications@github.com escribió:
Ah yeah. How should the position of it be done? Simply render the FAB and let the user decide where to place it? On 5 Jan 2016 9:00 p.m., "David Gil" notifications@github.com wrote:
What about a FAB?
— Reply to this email directly or view it on GitHub < https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169132655
.
— Reply to this email directly or view it on GitHub https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169133138 .
What about a Bottom Sheet?
Yes. The FAB has to be at the bottom-right according to the spec. Though FAB comes in handy, but, personally I somewhat like this article - Why the Floating Action Button is bad UX design
@Ehesp I can have a look at FAB, Gridview.
With respect to Grid View, I will be implementing this first (from the spec)-
@pewh problem with a bottom sheet is that currently there's no way to force a component to the top of everything else (I believe).
@pewh @Ehesp There is a way to do that. But, not sure its available on Android yet. We can tweak concepts and code from the Modal and implement it I believe. I have seen such an implementation somewhere. Not sure how good or feasible it is.
@bozzmob Okay cool - Shall look into it.
What does everyone think of 'Swipe Views with Tabs'? I've got it working on another project using the project mentioned in the list, but had to create a custom tab bar to make it feel native...?
Badge animations done!
@Ehesp Yeah! There is a ViewPager component which exists officially. We can make use of react-native-scrollable-tab-view as you have suggested. But, some css changes are needed so that the look and feel is similar to the existing components.
Nice work @Salakar, really cool.
@bozzmob I'll do that then as I've already got it on another project. react-native-scrollable-tab-view
doesn't allow a single tab too, but I've got a way around that.
@Ehesp How about we use react-native-action-button for FAB?
That looks good! Will look if there's any benefit of pulling it in and making a wrapper around it. If not, it might just be best to suggest this for a FAB.
A dropdown menu component could be awesome! But maybe it's a lot of work if it's a complete implementation (buttons, + textfields)
@zoontek I agree, however part of the problem we have (Bottom Sheets has this issue too), is that React Native does not yet support an "on the top of everything" API. So the dropdown menu might get stuck behind a component which is nested deeper down the chain.
I am working on the Gridview component now. Have made some progress. Still a lot to do.
Screenshots of Gridview-
Currently, its working for a fixed height, width.
I am working on making it a generic component. Currently most values like margin, padding are being hard-coded. So, thought of making it responsive.
@bozzmob any updates on the grid view?
@Salakar Yes. I am working on it. It should be available in a couple of days.
The dropdown is available in React-Native 0.19-rc: https://github.com/facebook/react-native/commit/18437093f2664beedd3239bb525d7daa3f2bcdbd :+1:
Awesome :D
I just wish there was some "z-index" type style so we could push whatever we wanted to the top of the stack.
Is the project dead? :(
Nope, was using it in a internal work project however that's not currently being developed so focus has shifted. Plan on picking it up in the next few weeks hopefully.
Great!
@Ehesp Any chance to integrate with https://github.com/xinthink/react-native-material-kit?
I would like to have a proper dialog (in future releases), example: https://github.com/aakashns/react-native-dialogs