search

invertase / react-native-material-design

React Native UI Components for Material Design
http://react-native-material-design.github.io
MIT License
3.15k stars 366 forks source link

Upgrade to use separate proptypes library for react 16 #172

Open suark opened 6 years ago

suark commented 6 years ago

In react 16 and up, React.Proptypes no longer exists. Instead we must use the new, separate proptypes library:
https://github.com/facebook/prop-types

react-native version 0.49 uses react 16 https://github.com/facebook/react-native/blob/v0.49.0/package.json#L135

So react-native-material-design must be updated or it will be remain incompatible with newer versions of react-native.

I have removed any references to the React.proptypes while also updating the dependency of react-native-vector-icons

That dependency has been updated to use the correct proptypes so we only have to update to the newest and it is fine.

I ran the linting and noticed that the master branch contains roughly 220 linting errors and after my changes, it still has the exact same number. So my PR should not be rejected due to linting errors that I did not cause.

Should resolve #170

amensouissi commented 6 years ago

Please merge this PR

tbarsbay commented 6 years ago

+1 to please merge this PR

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

suark commented 5 years ago

hopefully this is still possible. I deleted my fork haha. It was made almost 2 years ago