search

invertase / react-native-material-design

React Native UI Components for Material Design
http://react-native-material-design.github.io
MIT License
3.15k stars 365 forks source link

Fix depreciation warnings about importing React from React-Native package #62

Closed mlabrum closed 8 years ago

mlabrum commented 8 years ago

Requiring React API from react-native is now deprecated from 0.25 https://github.com/facebook/react-native/commit/0b534d1c3da9e3520bfd9b85bdd669db4d8c3b9f https://github.com/facebook/react-native/commit/2eafcd45dbd42f750df1ab9aa3770fed5cdf11ae https://github.com/facebook/react-native/releases/tag/v0.25.1

Used https://github.com/sibeliusseraphini/codemod-RN24-to-RN25

fixes: https://github.com/react-native-material-design/react-native-material-design/issues/61

Thanks,

miaodonghan commented 8 years ago

LGTM

mlabrum commented 8 years ago

I've just updated this pull request to update react-native-vector-icons to 2.0.1 which also solves the warnings from that.

it also adds support for allowFontScaling which unfortunately seems to be an IOS only property on react-native-vector-icons

miaodonghan commented 8 years ago

react native 0.26 is out. deprecation warnings are now errors. This needs to get in.

Ehesp commented 8 years ago

Will sort in a few hours, just back from holiday! On 19 May 2016 06:53, "Donghan Miao" notifications@github.com wrote:

react native 0.26 is out. deprecation warnings are now errors. This needs to get in.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/react-native-material-design/react-native-material-design/pull/62#issuecomment-220233923