search

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee
https://invertase.io/blog/open-sourcing-notifee
Other
465 stars 31 forks source link

feat(android): full-screen action #279

Closed helenaford closed 3 years ago

helenaford commented 3 years ago

Fulfils feature request for full-screen functionality https://github.com/notifee/react-native-notifee/issues/45

phildupuis commented 3 years ago

Does these changes are enough to make the full-screen intents work or is there additional changes to the aar needed ? We would like to try these changes on our side if possible.

mikehardy commented 3 years ago

@phildupuis there is a related PR that needs to land for the AAR either, and because I wish things were magical all the time but they are not, that PR became blocked on some tangential CI issue :facepalm:

I'll see if I can unstick that tomorrow, I have a few items on my Notifee list at this point so could do a batch of work

I still have on my list somehow seeing if we can work more closely with external contributors, it would obviously be great to have more energy and ever the optimist in these cases I continue to think there must be a way.

helenaford commented 3 years ago

p/r will be merged in this week's release. Part of this p/r requires documentation which is why it hasn't been merged straight away and as @mikehardy mentioned the CI issue we've been facing internally. Sorry for the delay, but thank you for your patience 🙏 🙌