fix(android, jwt): repair jwt gradle build dependency

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee

https://invertase.io/blog/open-sourcing-notifee

Other

465 stars 31 forks source link

fix(android, jwt): repair jwt gradle build dependency #293

Closed mikehardy closed 3 years ago

mikehardy commented 3 years ago

Related to #285 - when extracting the version I accidentally dropped the impl dependency

Where is the brown paper bag over head emoji?

This is the key line: https://github.com/notifee/react-native-notifee/compare/master...@mikehardy/fix-jwt-dependency?quick_pull=1#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aR81

This is the upstream install documentation for reference https://github.com/jwtk/jjwt#dependencies

helenaford commented 3 years ago

@mikehardy i just changed something slightly - not sure why but the def wasn’t working for me. maybe it was the single quotes? not sure, but I put the versions in place for now

mikehardy commented 3 years ago

Definitely the single vs double quotes - I noted that in the diff but let it pass through - I was editing in the Github web UI vs locally and actually running it :see_no_evil: - thanks for the patch up, sorry it happened!