mikehardy
commented
3 years ago @lucadegasperi I think you have just won my internet points for the day, though you may not want them since this looks like a real issue. Your hunch and that article look like a real problem in the library that you have exposed with clear detail.
Behold the way the library constructs the sound URI for notification channel creation:
public static @Nullable Uri getSoundUri(String sound) {
Context context = ContextHolder.getApplicationContext();
if (sound == null) {
return null;
} else if (sound.contains("://")) {
return Uri.parse(sound);
} else if (sound.equalsIgnoreCase("default")) {
return RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION);
} else {
int soundResourceId = getResourceIdByName(sound, "raw");
if (soundResourceId == 0 && sound.contains(".")) {
soundResourceId = getResourceIdByName(sound.substring(0, sound.lastIndexOf('.')), "raw");
}
if (soundResourceId == 0) {
return null;
}
return Uri.parse("android.resource://" + context.getPackageName() + "/" + soundResourceId);
}
}Looks to me like we are using resource IDs, and I'm familiar with how gradle handles resources so this does look like a clear problem to me.
It appears:
- sound URI construction needs to be by name reference for notification channel creation
- users with custom sounds need a clear and direct call to action in the changelog / release announcement directing users of the feature to create a new notification channel (with a new ID! so they really get a new channel) so they may experience reliable sound file reference even after rebuilds
I'd like help confirming I'm on the right path. Does that match your understanding?
lucadegasperi
mars-lan
Hello, A lot of our users are having problems with our notifications not playing any sounds after they download a new version of our app from the play store. When our app boots we create the notification channels as follows:
While trying to debug the issue I've noticed in the android settings of our app that instead of the sound named "notification" we had a random number like "123456789". This got me thinking that maybe that ID changes when the app gets rebuilt but since Notification channels are mostly read-only once created, that ID is no longer the actual sound ID, thus playing no sound when a notification is received after the app has been updated. I then stumbled across this article and It looks like he has a very similar issue to what we are experiencing. I was wondering, does Notifee create the notification channels in a similar way to what the article is reporting? Is the problem somewhere else?
Thank you again for your great work!