search

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee
https://invertase.io/blog/open-sourcing-notifee
Other
466 stars 31 forks source link

feat(android, sound): expose raw soundURI on android #342

Closed mikehardy closed 3 years ago

mikehardy commented 3 years ago

Related to #341 - this exposes the raw sound URI, and was used in testing on the related fix

For consideration: it may be useful to scan the NotificationChannelCompat API and incorporate all the new APIs for exposure but I fear scope creep / delay vs the necessary fix for #341

An easy+quick compromise might be to at least expose them all but mark them as read-only pending future support for setting them?

set of things not exposed includes information about conversations, whether user has customized a few items, and audio attributes (which may have been user-altered on the channel post-creation)

mikehardy commented 3 years ago

It appears this is not necessary / gating the core fix for custom sounds, so it may be a good opportunity to delay just a bit with it and add all the NotifcationChannelCompat accessors possible, as that's a pretty easy task anyway. I'm happy to do it, just looking for opinion I guess @helenaford whether you like the idea ?

mikehardy commented 3 years ago

I'll pursue adding more props to the channel object after your PR in the same area is in :muscle: