search

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee
https://invertase.io/blog/open-sourcing-notifee
Other
466 stars 31 forks source link

Android custom sound not found with extension (`sound.mp3`) is found with no extension (`sound`) #350

Closed mikehardy closed 3 years ago

mikehardy commented 3 years ago

Found the root cause of sound not playing. Previously the custom sound should include the file extension as shown in the doc, e.g. custom_sound.mp3. Starting 1.10.0 the extension shouldn't be included, e.g. custom_sound. Please update the documentation & releate note to reflect that.

Originally posted by @mars-lan in https://github.com/notifee/react-native-notifee/issues/341#issuecomment-890600319

helenaford commented 3 years ago

Fixed docs to reflect changes and also to mark the release as a breaking change - updates will be live on the website shortly https://github.com/notifee/documentation/commit/9f7a10b93ff2bc56f558164ac221b366575143f8

mars-lan commented 3 years ago

I wonder if we can do the same for iOS (i.e. without the file extension) for consistency?

mikehardy commented 3 years ago

Yes - sorry I didn't have time to investigate this myself, but @helenaford I was thinking this was more an unintentional regression and not using the extension is bad practice since extensions are really just a convention and the full file name should be used, apart from the idea that iOS should behave the same.

I was hoping to have time to actually post a fix for this so it used the whole file name (again?) + behaved the same as iOS