search

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee
https://invertase.io/blog/open-sourcing-notifee
Other
465 stars 31 forks source link

Remove @platform tags from docs which state `Trigger` is iOS specific #364

Closed liamjones closed 3 years ago

liamjones commented 3 years ago

...since it now works on Android too.

I was going to remove it from DisplayedNotification too (https://github.com/notifee/react-native-notifee/blob/master/src/types/Notification.ts#L126) but, from briefly testing it, it seems like you don't get the trigger property on Android when calling getDisplayedNotifications(). Is this a platform limitation on the Android side or an omission in Notifee and it should be present on both?

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

helenaford commented 3 years ago

@liamjones thanks for this p/r ❤️ it may be a limitation sadly, from what I remember which is why it's marked as iOS-only. but I will double-check and get back to you on this