search

invertase / react-native-notifee

Moved to https://github.com/invertase/notifee
https://invertase.io/blog/open-sourcing-notifee
Other
465 stars 31 forks source link

fix(android): add react-native 0.65 compatibility event emitter stubs #368

Closed mikehardy closed 3 years ago

mikehardy commented 3 years ago

Been working through this in a few modules as I test the react-native 0.65 upgrade in a work project in order to fuzz-bust all the libraries

Here's the same in react-native-firebase https://github.com/invertase/react-native-firebase/pull/5616/files#diff-c887076b0c80d540aed1bfbb472cc8f20516634e8e72d53014c65d690bba4fb1

Also did it in netinfo and device-info modules - all seems to be working fine after being released a couple days.

I have this patch already test-integrated in my project via patch-package

helenaford commented 3 years ago

@mikehardy LGTM. thanks for the fix. Will be doing a release tomorrow that can include it :)

mikehardy commented 3 years ago

had some issues with tests as mentioned on slack but this one works fine :-) - merged it so I can clean the branch and stay focused