invertase / stripe-firebase-extensions

Repository of Firebase Extensions built by Stripe.
https://firebase.google.com/products/extensions
Apache License 2.0
424 stars 161 forks source link

Shipping address is not collected if Stripe configuration collection set #455

Open jbrixon opened 1 year ago

jbrixon commented 1 year ago

Bug report

Describe the bug

Shipping address is not collected if a value for "Stripe configuration collection" is set.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Set a value for "Stripe configuration collection" in the extension configuration
  2. Follow the documentation for collecting a shipping address during checkout, and add the "shipping_countries" doc to the configured products collection
  3. The cloud function attempts to load the document from the configured configuration collection, but doesn't find it
  4. Shipping address is not collected

Expected behavior

The documentation to mention that if a value is given for the configuration collection, then the "shipping_countries" doc should be placed there instead. Otherwise, it would be good to check in both places for the "shipping_countries" doc, in case that config value is set.

zaizai123 commented 1 year ago

Any timeline for fixing this issue?

MATTYGILO commented 8 months ago

I'm getting this error how do I fix it?

jbrixon commented 8 months ago

I'm getting this error how do I fix it?

Just move the shipping_countries doc from the products collection to the config collection. These are the collections you configured in the stripe extension.

MATTYGILO commented 8 months ago

Many thanks @jbrixon, that fixed that problem. Now I have a problem: If a user uses Apple Pay it completes by passes the shipping address? How do I disable apple pay or force Apple Pay users to enter shipping address?

jbrixon commented 8 months ago

Sorry @MATTYGILO, that one's beyond me!