search

invertedtomato / crc

A flexible CRC implementation supporting most major algorithms. Also includes ability to support custom implementations.
MIT License
29 stars 10 forks source link

Nuget package contains Debug build of the library #1

Closed ied206 closed 4 years ago

ied206 commented 4 years ago

Hello, I have been trying to benchmark several C# and native implementations of CRC32 and CRC64. However, I found BenchmarkDotNet complaining about non-optmized binaries of InvertedTomato.Crc. Please update the nuget packages to the Release build, so people can use the optimized build.

C:\Joveler\Joveler.Compression\Benchmark>dotnet run -c Release -- hash
// Validating benchmarks:
Assembly Benchmark which defines benchmarks references non-optimized InvertedTomato.Crc
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.With(ConfigOptions.DisableOptimizationsValidator)'.
invertedtomato commented 4 years ago

Ah gee, good call! I've updated Nuget with the optimized binaries now. Thanks for pointing that out.

ied206 commented 4 years ago

The issue was solved in 1.1.3, thanks!