search

invertedtomato / crc

A flexible CRC implementation supporting most major algorithms. Also includes ability to support custom implementations.
MIT License
29 stars 10 forks source link

Add net48 test target, remove `<PublicSign>` from the non-NET7 distributables #15

Closed stevenaw closed 5 months ago

stevenaw commented 5 months ago

I noticed the library uses a few difference TFMs but only runs tests on .NET7. I tried adding a net48 test target to exercise the netstandard builds, but ran into a strong naming issue. I've worked around it by temporarily removing the <PublicSign> on the netstandard builds. All builds still use <SignAssembly> and sn -Tp shows a public key on the assembly for both netstandard + net7 builds.

The tests now pass for me on both net48 + net7 runtimes 😄

While the main docs don't mention much about compatibility, I found a bit of a write-up here outlining a few of the known issues within .NET Framework.

invertedtomato commented 5 months ago

Good one! It's hard to know how many people are still tied to .NET Framework. We're all .NET 8 here now. I'm happy to keep the support going so long as the project can stay up to date with the latest.

stevenaw commented 5 months ago

Thanks for the quick review and merge @invertedtomato !

victorsebrito commented 2 months ago

@invertedtomato I came across this issue and noticed the latest version of the package doesn't contain this fix. Could you please push a new version?

invertedtomato commented 2 months ago

Hey @victorsebrito , thanks for the bump. I've just published v1.4.0 on NuGet which removes all signing. It's not something I want to support going forward, particularly with the lack of value in the OSS space. If someone is super keen for signing they can fork or use another method that doesn't interfere with the majority case.