search

invertedtomato / crc

A flexible CRC implementation supporting most major algorithms. Also includes ability to support custom implementations.
MIT License
29 stars 10 forks source link

Minor cleanup #7

Closed maettu-this closed 1 year ago

maettu-this commented 1 year ago

Hi Ben,

Some minor cleanup:

Feel free to cherry-pick where you agree upon.

In addition, it could be considered to use mixed-case names to improve readability of well-known names:

Finally, do you know where "CRC-A" originates from? It seems weird seeing this without "16". And e.g. Rust crc_all doesn't list that one.

Best regards, Matthias

invertedtomato commented 1 year ago

Thanks @maettu-this, I'm very happy to include changes like this.

invertedtomato commented 1 year ago

Finally, do you know where "CRC-A" originates from? It seems weird seeing this without "16". And e.g. Rust crc_all doesn't list that one.

Sorry @maettu-this , I did miss this comment. No, it was many years ago when I wrote this. No idea where it came from. If you find that it's named incorrectly I'm happy to update it.