search

inviqa / dock-cli

Dock CLI
MIT License
39 stars 14 forks source link

[DnsDock] Fix for image name including forward slash #115

Closed wodor closed 8 years ago

wodor commented 8 years ago

If docker-compose.yml has an image name that contains forward slash like 

web:
    image: someone/image

It results in web.someone/image.docker DNS address and it does not work / seems to be an issue here

This PR enables removing everything before slash in container name. After this change dock-cli ps shows web.image.docker.

andytson-inviqa commented 8 years ago

underscore doesn't work very well in DNS domains

sroze commented 8 years ago

Thanks for this PR! Actually, you should remove the slash and everything before as it's dnsdock's strategy.

sroze commented 8 years ago

Thank you @wodor!